From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752651AbcAFJVD (ORCPT ); Wed, 6 Jan 2016 04:21:03 -0500 Received: from mx1a.lautre.net ([80.67.160.71]:35244 "EHLO mx1a.lautre.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752031AbcAFJU6 (ORCPT ); Wed, 6 Jan 2016 04:20:58 -0500 X-Greylist: delayed 356 seconds by postgrey-1.27 at vger.kernel.org; Wed, 06 Jan 2016 04:20:57 EST Message-ID: <1452071698.3035.0.camel@nonadev.net> Subject: Re: [PATCH 1/2] ext4: use XATTR_*_PREFIX_LEN instead sizeof(...) From: =?ISO-8859-1?Q?Jos=E9?= Bollo To: Toralf =?ISO-8859-1?Q?F=F6rster?= Cc: linux-security-module@vger.kernel.org, linux-ext4@vger.kernel.org, linux-kernel@vger.kernel.org Date: Wed, 06 Jan 2016 10:14:58 +0100 In-Reply-To: <1451850998-28639-1-git-send-email-toralf.foerster@gmx.de> References: <1451850998-28639-1-git-send-email-toralf.foerster@gmx.de> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.12.11 Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org I prefer the use of sizeof that can't be faked even by error but why not Le dimanche 03 janvier 2016 à 20:56 +0100, Toralf Förster a écrit : > use the definition in include/uapi/linux/xattr.h > > Signed-off-by: Toralf Förster > --- > fs/ext4/xattr_security.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/fs/ext4/xattr_security.c b/fs/ext4/xattr_security.c > index 36f4c1a..1a3d629 100644 > --- a/fs/ext4/xattr_security.c > +++ b/fs/ext4/xattr_security.c > @@ -16,7 +16,7 @@ ext4_xattr_security_list(const struct xattr_handler *handler, > struct dentry *dentry, char *list, size_t list_size, > const char *name, size_t name_len) > { > - const size_t prefix_len = sizeof(XATTR_SECURITY_PREFIX)-1; > + const size_t prefix_len = XATTR_SECURITY_PREFIX_LEN; > const size_t total_len = prefix_len + name_len + 1; > >