From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752583AbcAGN3P (ORCPT ); Thu, 7 Jan 2016 08:29:15 -0500 Received: from mailout4.w1.samsung.com ([210.118.77.14]:51353 "EHLO mailout4.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751121AbcAGN3N (ORCPT ); Thu, 7 Jan 2016 08:29:13 -0500 X-AuditID: cbfec7f4-f79026d00000418a-d3-568e6826ce16 From: Andrzej Hajda To: Kalle Valo , Shahar Patury , linux-wireless@vger.kernel.org (open list:TI WILINK WIRELESS DRIVERS) Cc: Andrzej Hajda , Bartlomiej Zolnierkiewicz , Marek Szyprowski , netdev@vger.kernel.org (open list:NETWORKING DRIVERS), linux-kernel@vger.kernel.org (open list) Subject: [PATCH] wlcore: fix error handling in wlcore_event_fw_logger Date: Thu, 07 Jan 2016 14:28:50 +0100 Message-id: <1452173330-19963-1-git-send-email-a.hajda@samsung.com> X-Mailer: git-send-email 1.9.1 X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFvrDJMWRmVeSWpSXmKPExsVy+t/xq7pqGX1hBtd/KVncWneO1WLjjPWs FotWLmSzuLxrDpvFmxV32C3WHrnLbnFsgZjFgwOfmRw4PC739TJ59G1Zxehx/MZ2Jo/Pm+QC WKK4bFJSczLLUov07RK4MhZOfMVYsJW94suxlYwNjOvYuhg5OSQETCQOHj3KCmGLSVy4tx4o zsUhJLCUUaJjxmUWCKeJSeLbuqXsIFVsApoSfzffBOsWEehjlDh2wAekiFngM6PE5y/vmEAS wgKuEvP3XGUGsVkEVCX27rwF1sAr4Czx6fF2Foh1chInj01mncDIvYCRYRWjaGppckFxUnqu oV5xYm5xaV66XnJ+7iZGSJh82cG4+JjVIUYBDkYlHt6OtN4wIdbEsuLK3EOMEhzMSiK80l59 YUK8KYmVValF+fFFpTmpxYcYpTlYlMR55+56HyIkkJ5YkpqdmlqQWgSTZeLglGpgVJR/YKPX kfhoWZ9PmERb7oKrEozL2y4ZaF9dMYvh+3s+gbu1yZd5py15398VdKzF6KkAc6hdasGl++zW IXP4tcRa+tf6LBJ8LSR2OqKs4NRuz5S5wguYFOJzX7KplNy7ynxgp0fyErm66a+nLhNxqtb8 eEy/TFeiiDfBgCH+1qplen9dV/1UYinOSDTUYi4qTgQACczRVg8CAAA= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org wlcore_read/wlcore_write can return negative values so it should be assigned to signed variable. The problem has been detected using proposed semantic patch scripts/coccinelle/tests/unsigned_lesser_than_zero.cocci [1]. [1]: http://permalink.gmane.org/gmane.linux.kernel/2120705 Fixes: 3719c17e1816 ("wlcore/wl18xx: fw logger over sdio") Signed-off-by: Andrzej Hajda --- drivers/net/wireless/ti/wlcore/event.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/wireless/ti/wlcore/event.c b/drivers/net/wireless/ti/wlcore/event.c index c964054..4b59f67 100644 --- a/drivers/net/wireless/ti/wlcore/event.c +++ b/drivers/net/wireless/ti/wlcore/event.c @@ -38,7 +38,7 @@ int wlcore_event_fw_logger(struct wl1271 *wl) { - u32 ret; + int ret; struct fw_logger_information fw_log; u8 *buffer; u32 internal_fw_addrbase = WL18XX_DATA_RAM_BASE_ADDRESS; -- 1.9.1