From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754343AbcAHI56 (ORCPT ); Fri, 8 Jan 2016 03:57:58 -0500 Received: from mga14.intel.com ([192.55.52.115]:14872 "EHLO mga14.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751700AbcAHI5z (ORCPT ); Fri, 8 Jan 2016 03:57:55 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.20,537,1444719600"; d="scan'208";a="888967023" Message-ID: <1452243464.30729.430.camel@linux.intel.com> Subject: Re: [PATCH 1/3] ata: sata_dwc_460ex: use "dmas" DT property to find dma channel From: Andy Shevchenko To: =?ISO-8859-1?Q?M=E5ns_Rullg=E5rd?= Cc: Andy Shevchenko , Julian Margetson , Tejun Heo , linux-ide@vger.kernel.org, "linux-kernel@vger.kernel.org" Date: Fri, 08 Jan 2016 10:57:44 +0200 In-Reply-To: References: <1450221935-6034-1-git-send-email-mans@mansr.com> <5675A84F.2070208@candw.ms> <5675BB2F.6060107@candw.ms> <5675C452.2080206@candw.ms> <5676E906.1060603@candw.ms> <1450724880.30729.250.camel@linux.intel.com> <1450731289.30729.282.camel@linux.intel.com> <1450781890.30729.298.camel@linux.intel.com> <1452159294.30729.405.camel@linux.intel.com> Organization: Intel Finland Oy Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.18.2-1 Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 2016-01-07 at 18:32 +0000, Måns Rullgård wrote: > Andy Shevchenko writes: > > > On Wed, 2016-01-06 at 19:36 +0200, Andy Shevchenko wrote: > > >  > > So, Måns, Julian, I just have published my repository containing > > Måns' > > and my patches regarding dw_dmac and sata_dwc_460ex drivers here > > > > https://bitbucket.org/andy-shev/linux/branch/topic%2Fdw%2Fnext > > I've picked out the relevant changes from your branch and made some > additional improvements.  A few notes: > > - The __be32/__le32 typedefs for the DMA descriptor fields are > necessary >   to avoid a million sparse warnings (and sparse is correct to warn). Hmm… Which version of sparse are you using? I always run builds with sparse enabled and didn't see anything. > - Using #ifdef CONFIG_AVR32 is a step back, IMO, since this driver > may >   well be used on another big endian system some day.  The Kconfig > logic >   for selecting this option could perhaps be improved though. Maybe runtime chosen accessors will be better than ifdefs? I don't like the Kconfig option which limits application of the (compiled) driver. > > Tested on AVR32 (DMA driver) and Sigma SMP8642 (SATA driver). > > Code here: > https://bitbucket.org/mansr/linux-dwc/branch/dwc-sata Thanks for testing! -- Andy Shevchenko Intel Finland Oy