From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755381AbcAIRcl (ORCPT ); Sat, 9 Jan 2016 12:32:41 -0500 Received: from out4-smtp.messagingengine.com ([66.111.4.28]:58859 "EHLO out4-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754490AbcAIRcj (ORCPT ); Sat, 9 Jan 2016 12:32:39 -0500 Message-Id: <1452360758.672752.487412298.7D14D501@webmail.messagingengine.com> X-Sasl-Enc: KvYBndIUX96xgndw/xeR4Cz/pVKExYSSEDtSqR4hwbxx 1452360758 From: Henrique de Moraes Holschuh To: Eric Curtin , David Herrmann Cc: Darren Hart , platform-driver-x86@vger.kernel.org, ibm-acpi-devel@lists.sourceforge.net, "linux-kernel" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Type: text/plain X-Mailer: MessagingEngine.com Webmail Interface - ajax-6cda141f Subject: Re: [PATCH] thinkpad_acpi: don't yell on unsupported brightness interfaces Date: Sat, 09 Jan 2016 15:32:38 -0200 In-Reply-To: References: <1445424370-4725-1-git-send-email-dh.herrmann@gmail.com> <1445438032.750540.416379153.1ECC9658@webmail.messagingengine.com> <20151021144410.GB29166@vmdeb7> <20151106175706.GE18221@malice.jf.intel.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jan 8, 2016, at 15:26, Eric Curtin wrote: > As regards the "Unsupported brightness interface" log message will I > add 101 to the switch statement so it doesn't get reported on my device > or just remove it? This seems to be reporting many false positives (or > negatives whatever way you want to look at it) on different machines so > can I remove this logging? Either remove the message, or leave it at debug level. Do not add 101 to the switch case, please. -- "One disk to rule them all, One disk to find them. One disk to bring them all and in the darkness grind them. In the Land of Redmond where the shadows lie." -- The Silicon Valley Tarot Henrique Holschuh