From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1762846AbcALPib (ORCPT ); Tue, 12 Jan 2016 10:38:31 -0500 Received: from shell.v3.sk ([92.60.52.57]:37412 "EHLO shell.v3.sk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753037AbcALPi3 convert rfc822-to-8bit (ORCPT ); Tue, 12 Jan 2016 10:38:29 -0500 X-Greylist: delayed 379 seconds by postgrey-1.27 at vger.kernel.org; Tue, 12 Jan 2016 10:38:29 EST Message-ID: <1452612711.18559.62.camel@v3.sk> Subject: Re: [PATCH 1/3] ifb: make device count build-time configurable From: Lubomir Rintel To: Daniel Borkmann Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, "David S. Miller" , Jamal Hadi Salim Date: Tue, 12 Jan 2016 16:31:51 +0100 In-Reply-To: <5695199E.2040303@iogearbox.net> References: <1452599804-27284-1-git-send-email-lkundrak@v3.sk> <5695199E.2040303@iogearbox.net> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.18.3 (3.18.3-1.fc23) Mime-Version: 1.0 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 2016-01-12 at 16:19 +0100, Daniel Borkmann wrote: > On 01/12/2016 12:56 PM, Lubomir Rintel wrote: > > The devices can be created at run-time for quite some time already > > and the > > load-time device creation collides with attempts to create the > > device of > > the same name: > > > >    # rmmod ifb > >    # ip link add ifb0 type ifb > >    RTNETLINK answers: File exists > > > > This is pretty much the same situation as was with the block loop > > devices > > which was solved by adding a build-time configuration that the > > distributions could use as they deem fit while keeping the default > > for > > compatibility. > > > > Let's do that here as well. > > Thanks for the set in general, good to see it fixed! > > > Signed-off-by: Lubomir Rintel > > --- > [...] > > +config IFB_COUNT > > +        int "Number of ifb devices to pre-create at init time" > > +        depends on IFB > > +        default 3 > > Should that not be 2? Yes, it should be. Good catch, thanks. Will follow-up with a fixed patch. Lubo