From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1761884AbcALQEj (ORCPT ); Tue, 12 Jan 2016 11:04:39 -0500 Received: from out4-smtp.messagingengine.com ([66.111.4.28]:45562 "EHLO out4-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1760156AbcALQEg convert rfc822-to-8bit (ORCPT ); Tue, 12 Jan 2016 11:04:36 -0500 Message-Id: <1452614675.376008.489962970.24E13AB9@webmail.messagingengine.com> X-Sasl-Enc: YZ4gLazlwTp+dZhFLufGkgJVRRRmuJNdOY/2sFfmBmL6 1452614675 From: Henrique de Moraes Holschuh To: =?ISO-8859-1?Q?Pali=20Roh=E1r?= Cc: Darren Hart , Pavel Machek , ibm-acpi-devel@lists.sourceforge.net, platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org, "Fabio D'Urso" MIME-Version: 1.0 Content-Transfer-Encoding: 8BIT Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: MessagingEngine.com Webmail Interface - ajax-6cda141f In-Reply-To: <201601112103.01145@pali> References: <1450982818-11694-1-git-send-email-pali.rohar@gmail.com> <20160111190411.GE10643@malice.jf.intel.com> <1452540480.2848000.489039714.26068C20@webmail.messagingengine.com> <201601112103.01145@pali> Subject: Re: [PATCH] thinkpad_acpi: Add support for keyboard backlight Date: Tue, 12 Jan 2016 14:04:35 -0200 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jan 11, 2016, at 18:03, Pali Rohár wrote: > On Monday 11 January 2016 20:28:00 Henrique de Moraes Holschuh wrote > > The two features are not the same (and are handled differently by the > > firmware, for whatever reason), although they do serve the same > > purpose. I don't think a thinkpad will ever have both features at > > the same time, so I have no idea why they changed the firmware > > interface. > > Maybe we should decide if ::kbd_backlight LED suffix could be used also > for other LED devices and not only for those which are physically under > the keyboard. Maybe, but that doesn't matter for thinkpad-acpi: the "thinklight" LED name is kernel-userspace ABI so frozen by years and years of use that it is not even funny. It cannot be changed. > At least I understand "keyboard backlight" as light which is under the > keyboard... So do I... > And more important, I was told that ThinkPad x230 comes in variant with > both ThinkLight (that LED upper the display) and keyboard backlight > (under they keyboard). Ok, so there is yet another damn good reason to keep both separate. -- "One disk to rule them all, One disk to find them. One disk to bring them all and in the darkness grind them. In the Land of Redmond where the shadows lie." -- The Silicon Valley Tarot Henrique Holschuh