From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934153AbcAMLvI (ORCPT ); Wed, 13 Jan 2016 06:51:08 -0500 Received: from mx2.suse.de ([195.135.220.15]:49579 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755046AbcAMLvF (ORCPT ); Wed, 13 Jan 2016 06:51:05 -0500 From: Juergen Gross To: Douglas_Warzecha@dell.com, Srinivas_G_Gowda@dell.com, linux-kernel@vger.kernel.org Cc: Juergen Gross Subject: [PATCH] dcdbas: don't limit SMIs to cpu 0 Date: Wed, 13 Jan 2016 12:51:00 +0100 Message-Id: <1452685860-17569-1-git-send-email-jgross@suse.com> X-Mailer: git-send-email 2.6.2 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org SMIs in the Dell dcdbas firmware driver don't need to be raised on cpu 0. So remove the binding of the current thread to cpu 0 before doing the SMI. Signed-off-by: Juergen Gross --- drivers/firmware/dcdbas.c | 21 +-------------------- 1 file changed, 1 insertion(+), 20 deletions(-) diff --git a/drivers/firmware/dcdbas.c b/drivers/firmware/dcdbas.c index 829eec8..3cde963 100644 --- a/drivers/firmware/dcdbas.c +++ b/drivers/firmware/dcdbas.c @@ -245,28 +245,12 @@ static ssize_t host_control_on_shutdown_store(struct device *dev, */ int dcdbas_smi_request(struct smi_cmd *smi_cmd) { - cpumask_var_t old_mask; - int ret = 0; - if (smi_cmd->magic != SMI_CMD_MAGIC) { dev_info(&dcdbas_pdev->dev, "%s: invalid magic value\n", __func__); return -EBADR; } - /* SMI requires CPU 0 */ - if (!alloc_cpumask_var(&old_mask, GFP_KERNEL)) - return -ENOMEM; - - cpumask_copy(old_mask, ¤t->cpus_allowed); - set_cpus_allowed_ptr(current, cpumask_of(0)); - if (smp_processor_id() != 0) { - dev_dbg(&dcdbas_pdev->dev, "%s: failed to get CPU 0\n", - __func__); - ret = -EBUSY; - goto out; - } - /* generate SMI */ /* inb to force posted write through and make SMI happen now */ asm volatile ( @@ -280,10 +264,7 @@ int dcdbas_smi_request(struct smi_cmd *smi_cmd) : "memory" ); -out: - set_cpus_allowed_ptr(current, old_mask); - free_cpumask_var(old_mask); - return ret; + return 0; } /** -- 2.6.2