From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753353AbcANJon (ORCPT ); Thu, 14 Jan 2016 04:44:43 -0500 Received: from mga09.intel.com ([134.134.136.24]:65422 "EHLO mga09.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752027AbcANJoj (ORCPT ); Thu, 14 Jan 2016 04:44:39 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.22,293,1449561600"; d="scan'208";a="633265814" Message-ID: <1452764705.2521.29.camel@linux.intel.com> Subject: Re: [PATCH v1 1/2] lib/string_helpers: export string_units_{2,10} for others From: Andy Shevchenko To: Robert Elliott , Matt Fleming , Andrew Morton , linux-efi@vger.kernel.org, Thomas Gleixner , Ingo Molnar , "H. Peter Anvin" , linux-kernel@vger.kernel.org Date: Thu, 14 Jan 2016 11:45:05 +0200 In-Reply-To: <1452604386-13673-1-git-send-email-andriy.shevchenko@linux.intel.com> References: <1452604386-13673-1-git-send-email-andriy.shevchenko@linux.intel.com> Organization: Intel Finland Oy Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.18.3-1 Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 2016-01-12 at 15:13 +0200, Andy Shevchenko wrote: > There is one user coming which would like to use those string arrays. > It might > be useful for any other user in the future. Please, comment on the idea, but discard both patches, I'm cooking better approach. > > Signed-off-by: Andy Shevchenko > --- >  include/linux/string_helpers.h |  3 +++ >  lib/string_helpers.c           | 21 ++++++++++++--------- >  2 files changed, 15 insertions(+), 9 deletions(-) > > diff --git a/include/linux/string_helpers.h > b/include/linux/string_helpers.h > index dabe643..1d16240 100644 > --- a/include/linux/string_helpers.h > +++ b/include/linux/string_helpers.h > @@ -10,6 +10,9 @@ enum string_size_units { >   STRING_UNITS_2, /* use binary powers of 2^10 > */ >  }; >   > +extern const char *const string_units_10[]; > +extern const char *const string_units_2[]; > + >  void string_get_size(u64 size, u64 blk_size, enum string_size_units > units, >        char *buf, int len); >   > diff --git a/lib/string_helpers.c b/lib/string_helpers.c > index 5939f63..3a4c812 100644 > --- a/lib/string_helpers.c > +++ b/lib/string_helpers.c > @@ -13,6 +13,15 @@ >  #include >  #include >   > +const char * const string_units_10[] = { > + "B", "kB", "MB", "GB", "TB", "PB", "EB", "ZB", "YB", > +}; > +EXPORT_SYMBOL(string_units_10); > +const char * const string_units_2[] = { > + "B", "KiB", "MiB", "GiB", "TiB", "PiB", "EiB", "ZiB", "YiB", > +}; > +EXPORT_SYMBOL(string_units_2); > + >  /** >   * string_get_size - get the size in the specified units >   * @size: The size to be converted in blocks > @@ -29,15 +38,9 @@ >  void string_get_size(u64 size, u64 blk_size, const enum > string_size_units units, >        char *buf, int len) >  { > - static const char *const units_10[] = { > - "B", "kB", "MB", "GB", "TB", "PB", "EB", "ZB", "YB" > - }; > - static const char *const units_2[] = { > - "B", "KiB", "MiB", "GiB", "TiB", "PiB", "EiB", > "ZiB", "YiB" > - }; >   static const char *const *const units_str[] = { > - [STRING_UNITS_10] = units_10, > - [STRING_UNITS_2] = units_2, > + [STRING_UNITS_10] = string_units_10, > + [STRING_UNITS_2] = string_units_2, >   }; >   static const unsigned int divisor[] = { >   [STRING_UNITS_10] = 1000, > @@ -92,7 +95,7 @@ void string_get_size(u64 size, u64 blk_size, const > enum string_size_units units, >   } >   >   out: > - if (i >= ARRAY_SIZE(units_2)) > + if (i >= ARRAY_SIZE(string_units_2)) >   unit = "UNK"; >   else >   unit = units_str[units][i]; -- Andy Shevchenko Intel Finland Oy