From: Chen Feng <puck.chen@hisilicon.com>
To: <gregkh@linuxfoundation.org>, <arve@android.com>,
<riandrews@android.com>, <paul.gortmaker@windriver.com>,
<labbott@redhat.com>, <gioh.kim@lge.com>,
<tranmanphong@gmail.com>, <mitchelh@codeaurora.org>,
<devel@driverdev.osuosl.org>, <linux-kernel@vger.kernel.org>,
<puck.chen@hisilicon.com>, <yudongbin@hisilicon.com>,
<saberlily.xia@hisilicon.com>, <suzhuangluan@hisilicon.com>,
<kong.kongxinwei@hisilicon.com>, <xuyiping@hisilicon.com>,
<z.liuxinliang@hisilicon.com>, <weidong2@hisilicon.com>,
<w.f@huawei.com>, <puck.chen@foxmail.com>,
<shimingxing@hisilicon.com>, <oliver.fu@hisilicon.com>,
<albert.lubing@hisilicon.com>, <chenxiang9@huawei.com>,
<liuzixing@huawei.com>, <haojian.zhuang@linaro.org>
Cc: <qijiwen@hisilicon.com>, <peter.panshilin@hisilicon.com>,
<dan.zhao@hisilicon.com>, <linuxarm@huawei.com>,
<dev@lists.96boards.org>
Subject: [PATCH] staging: ion: make the pte default none PTE_RDONLY
Date: Fri, 15 Jan 2016 10:42:33 +0800 [thread overview]
Message-ID: <1452825753-36364-1-git-send-email-puck.chen@hisilicon.com> (raw)
The page is already alloc at ion_alloc function,
ion_mmap map the alloced pages to user-space.
The default prot can be PTE_RDONLY. Take a look at
here:
set_pte_at()
arch/arm64/include/asm:
if (pte_dirty(pte) && pte_write(pte))
pte_val(pte) &= ~PTE_RDONLY;
else
pte_val(pte) |= PTE_RDONLY;
So with the dirty bit,it can improve the efficiency
and donnot need to handle memory fault when use access.
Signed-off-by: Chen Feng <puck.chen@hisilicon.com>
Signed-off-by: Wei Dong <weidong2@hisilicon.com>
Reviewed-by: Zhuangluan Su <suzhuangluan@hisilicon.com>
---
drivers/staging/android/ion/ion.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/staging/android/ion/ion.c b/drivers/staging/android/ion/ion.c
index e237e9f..dba5942 100644
--- a/drivers/staging/android/ion/ion.c
+++ b/drivers/staging/android/ion/ion.c
@@ -1026,6 +1026,9 @@ static int ion_mmap(struct dma_buf *dmabuf, struct vm_area_struct *vma)
if (!(buffer->flags & ION_FLAG_CACHED))
vma->vm_page_prot = pgprot_writecombine(vma->vm_page_prot);
+ /*Default writeable*/
+ vma->vm_page_prot = pte_mkdirty(vma->vm_page_prot);
+
mutex_lock(&buffer->lock);
/* now map it to userspace */
ret = buffer->heap->ops->map_user(buffer->heap, buffer, vma);
--
1.9.1
next reply other threads:[~2016-01-15 2:42 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-15 2:42 Chen Feng [this message]
2016-01-15 2:58 ` kbuild test robot
2016-01-15 3:10 ` kbuild test robot
2016-01-15 23:03 ` Laura Abbott
2016-01-15 23:23 ` Russell King - ARM Linux
2016-01-18 3:44 ` chenfeng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1452825753-36364-1-git-send-email-puck.chen@hisilicon.com \
--to=puck.chen@hisilicon.com \
--cc=albert.lubing@hisilicon.com \
--cc=arve@android.com \
--cc=chenxiang9@huawei.com \
--cc=dan.zhao@hisilicon.com \
--cc=dev@lists.96boards.org \
--cc=devel@driverdev.osuosl.org \
--cc=gioh.kim@lge.com \
--cc=gregkh@linuxfoundation.org \
--cc=haojian.zhuang@linaro.org \
--cc=kong.kongxinwei@hisilicon.com \
--cc=labbott@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxarm@huawei.com \
--cc=liuzixing@huawei.com \
--cc=mitchelh@codeaurora.org \
--cc=oliver.fu@hisilicon.com \
--cc=paul.gortmaker@windriver.com \
--cc=peter.panshilin@hisilicon.com \
--cc=puck.chen@foxmail.com \
--cc=qijiwen@hisilicon.com \
--cc=riandrews@android.com \
--cc=saberlily.xia@hisilicon.com \
--cc=shimingxing@hisilicon.com \
--cc=suzhuangluan@hisilicon.com \
--cc=tranmanphong@gmail.com \
--cc=w.f@huawei.com \
--cc=weidong2@hisilicon.com \
--cc=xuyiping@hisilicon.com \
--cc=yudongbin@hisilicon.com \
--cc=z.liuxinliang@hisilicon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®