From: Alexandre Belloni <alexandre.belloni@free-electrons.com>
To: bigeasy@linutronix.de, Thomas Gleixner <tglx@linutronix.de>
Cc: Boris Brezillon <boris.brezillon@free-electrons.com>,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-rt-users@vger.kernel.org,
Nicolas Ferre <nicolas.ferre@atmel.com>,
Alexandre Belloni <alexandre.belloni@free-electrons.com>
Subject: Fix preempt-rt on AT91
Date: Sun, 17 Jan 2016 03:23:13 +0100 [thread overview]
Message-ID: <1452997394-8554-1-git-send-email-alexandre.belloni@free-electrons.com> (raw)
Hi Sebastian, Thomas,
Preemp-rt on at91 has multiple issues:
1/ After apply the preempt-rt patch, the kernel doesn't build anymore,
arm-at91-pit-remove-irq-handler-when-clock-is-unused.patch is not correct
anymore. Can you squash the following patch to solve this build issue?
2/ This approach actually has more issues, in particular, request_irq() must
not be calls from interrupt disabled context. That only works because
might_sleep() is not active during early boot.
For more information, see the following discussion:
http://lists.infradead.org/pipermail/linux-arm-kernel/2015-July/357607.html
However, we can't remove those patches now because else we would suffer from
another issue:
The timer interrupt is shared with other devices, in particular the debug tty,
the rtc dans the pmc. When using preempt-rt, those interrupts become threaded
interrupts. But, the pit interrupt is requested with IRQF_TIMER and so has
IRQF_NO_THREAD. If the pit interrupt is not freed at early boot, all the other
devices will fail requesting their interrupt, for example:
genirq: Flags mismatch irq 16. 00042080 (ttyS0) vs. 00015280 (at91_tick)
atmel_usart ffffee00.serial: atmel_startup - Can't get irq
I'd say that the proper solution would still be to implement the virtual
irqchip because this would still hit people not wanting to use the TCB as
their clock source.
3/ Finally, the kernel will crash when initializing the PMC driver. This is
solved by this series that will hopefully land in the mainline:
http://lists.infradead.org/pipermail/linux-arm-kernel/2015-December/390954.html
Alexandre Belloni (1):
fix arm-at91-pit-remove-irq-handler-when-clock-is-unused.patch
drivers/clocksource/timer-atmel-pit.c | 68 +++++++++++++++++------------------
drivers/clocksource/timer-atmel-st.c | 8 ++---
2 files changed, 38 insertions(+), 38 deletions(-)
--
2.5.0
next reply other threads:[~2016-01-17 2:23 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-17 2:23 Alexandre Belloni [this message]
2016-01-17 2:23 ` [PATCH 4.4-rt2] fix arm-at91-pit-remove-irq-handler-when-clock-is-unused.patch Alexandre Belloni
2016-01-18 17:25 ` Sebastian Andrzej Siewior
2016-01-18 18:42 ` Alexandre Belloni
2016-01-18 20:24 ` Sebastian Andrzej Siewior
2016-01-19 1:22 ` Alexandre Belloni
2016-01-20 11:07 ` Thomas Gleixner
2016-03-17 19:55 ` Alexandre Belloni
2016-01-18 17:42 ` Fix preempt-rt on AT91 Sebastian Andrzej Siewior
2016-01-18 19:23 ` Alexandre Belloni
2016-01-18 20:30 ` Sebastian Andrzej Siewior
2016-01-19 1:02 ` Alexandre Belloni
2016-03-05 11:35 ` Alexandre Belloni
2016-03-08 11:06 ` Sebastian Andrzej Siewior
2016-03-08 11:26 ` Thomas Gleixner
2016-03-08 18:39 ` Alexandre Belloni
2016-03-09 9:58 ` arm: at91: do not disable/enable clocks in a row Sebastian Andrzej Siewior
2016-03-17 18:09 ` Alexandre Belloni
2016-02-18 20:16 ` Fix preempt-rt on AT91 Jean-Denis Girard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1452997394-8554-1-git-send-email-alexandre.belloni@free-electrons.com \
--to=alexandre.belloni@free-electrons.com \
--cc=bigeasy@linutronix.de \
--cc=boris.brezillon@free-electrons.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rt-users@vger.kernel.org \
--cc=nicolas.ferre@atmel.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®