From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from cstnet.cn (smtp21.cstnet.cn [159.226.251.21]) (using TLSv1.2 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 57AF03CF034 for ; Tue, 5 May 2026 09:06:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=159.226.251.21 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777971970; cv=none; b=mXgiByDmVRFuc7tNOfjEfARfwLUCBTw0Crd8V3hVdfFyX+o0aSRbUn1uAPwFkqsHCk8IhqG89MWs+uHSK7S1wTOulfMZJFcTlFpnPPA43po8fGtzuP4OtvJwt7GVh+61FLZg3MKdeJgr3+6ADSDGUmRc7oitEf5zJ472CWGAHD4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777971970; c=relaxed/simple; bh=Jo6HZi0PM7+YOTih0+cEDQepWV2ndO4NYMHBI3Rx3Jw=; h=Message-ID:Subject:From:To:Cc:Date:In-Reply-To:References: Content-Type:MIME-Version; b=I4JhZbRGnvMnaVoTcl8ne5QSVDd8smms8eh91mr1yZ1cjq8HvXdsesPkPLN7VWqgnzseh1EhTf/hheGoB1XHK88LSOP+zx/G2F8OltCZe8bjuwooCS5bTsdZKqqZFLHuxmRtFE/Bb8xFyJ9K60lSkg60CgKD5RnYvW0WdY/y6vk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=iscas.ac.cn; spf=pass smtp.mailfrom=iscas.ac.cn; arc=none smtp.client-ip=159.226.251.21 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=iscas.ac.cn Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=iscas.ac.cn Received: from edelgard.fodlan.icenowy.me (unknown [112.94.100.82]) by APP-01 (Coremail) with SMTP id qwCowAC3XmrysvlpnwpUDw--.8821S2; Tue, 05 May 2026 17:05:54 +0800 (CST) Message-ID: <1452a2d0d1f32afbd37fad2935a6e137c1e707be.camel@iscas.ac.cn> Subject: Re: [PATCH] drm: verisilicon: support non-coherent DMA framebuffers From: Icenowy Zheng To: Dominique Belhachemi Cc: Maxime Ripard , Maarten Lankhorst , Thomas Zimmermann , David Airlie , Simona Vetter , Paul Cercueil , Michal Wilczynski , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Date: Tue, 05 May 2026 17:05:54 +0800 In-Reply-To: <20260505042631.1916555-1-domibel@debian.org> References: <20260505042631.1916555-1-domibel@debian.org> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.58.3 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-CM-TRANSID:qwCowAC3XmrysvlpnwpUDw--.8821S2 X-Coremail-Antispam: 1UD129KBjvJXoW3AFy7Xr1fKry7WFy3Wr4UArb_yoW7Kr4Dpa 1DAFW5KrWUtw4kGr9rJF1qkay3Cw1xKa4Igry8GwnI9r1Yyr98X3WrGr9xuF45JrW7G3WS qwsFkF1DCr47Cr7anT9S1TB71UUUUU7qnTZGkaVYY2UrUUUUjbIjqfuFe4nvWSU5nxnvy2 9KBjDU0xBIdaVrnRJUUUvmb7Iv0xC_tr1lb4IE77IF4wAFF20E14v26r4j6ryUM7CY07I2 0VC2zVCF04k26cxKx2IYs7xG6rWj6s0DM7CIcVAFz4kK6r1j6r18M28lY4IEw2IIxxk0rw A2F7IY1VAKz4vEj48ve4kI8wA2z4x0Y4vE2Ix0cI8IcVAFwI0_JFI_Gr1l84ACjcxK6xII jxv20xvEc7CjxVAFwI0_Gr0_Cr1l84ACjcxK6I8E87Iv67AKxVWxJr0_GcWl84ACjcxK6I 8E87Iv6xkF7I0E14v26F4UJVW0owAS0I0E0xvYzxvE52x082IY62kv0487Mc02F40EFcxC 0VAKzVAqx4xG6I80ewAv7VC0I7IYx2IY67AKxVWUGVWUXwAv7VC2z280aVAFwI0_Jr0_Gr 1lOx8S6xCaFVCjc4AY6r1j6r4UM4x0Y48IcVAKI48JM4IIrI8v6xkF7I0E8cxan2IY04v7 MxkF7I0En4kS14v26r1q6r43MxAIw28IcxkI7VAKI48JMxC20s026xCaFVCjc4AY6r1j6r 4UMI8I3I0E5I8CrVAFwI0_Jr0_Jr4lx2IqxVCjr7xvwVAFwI0_JrI_JrWlx4CE17CEb7AF 67AKxVWUtVW8ZwCIc40Y0x0EwIxGrwCI42IY6xIIjxv20xvE14v26r1j6r1xMIIF0xvE2I x0cI8IcVCY1x0267AKxVW8JVWxJwCI42IY6xAIw20EY4v20xvaj40_Jr0_JF4lIxAIcVC2 z280aVAFwI0_Jr0_Gr1lIxAIcVC2z280aVCY1x0267AKxVW8JVW8JrUvcSsGvfC2KfnxnU UI43ZEXa7IU8U5r7UUUUU== X-CM-SenderInfo: x2kh0wp0lqwv3d6l2u1dvotugofq/ =E5=9C=A8 2026-05-05=E4=BA=8C=E7=9A=84 04:26 +0000=EF=BC=8CDominique Belhac= hemi=E5=86=99=E9=81=93=EF=BC=9A > Wire up the standard non-coherent path matching the ingenic DRM > driver. Ah I forgot that my test platform is also noncoherent -- it uses uncached memory map instead of cache maintenance. Should some other facility to be wired in to check whether cache maintenance or uncached mapping is available and use that functionality? Thanks, Icenowy >=20 > Tested on StarFive JH7110 (VisionFive 2 v1.3B). >=20 > Signed-off-by: Dominique Belhachemi > --- > =C2=A0drivers/gpu/drm/verisilicon/vs_drm.c=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0 | 31 > +++++++++++++++++-- > =C2=A0drivers/gpu/drm/verisilicon/vs_drm.h=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0 |=C2=A0 7 +++++ > =C2=A0.../gpu/drm/verisilicon/vs_primary_plane.c=C2=A0=C2=A0=C2=A0 | 11 += +++++- > =C2=A03 files changed, 46 insertions(+), 3 deletions(-) >=20 > diff --git a/drivers/gpu/drm/verisilicon/vs_drm.c > b/drivers/gpu/drm/verisilicon/vs_drm.c > index fd259d53f49f..52d8749445df 100644 > --- a/drivers/gpu/drm/verisilicon/vs_drm.c > +++ b/drivers/gpu/drm/verisilicon/vs_drm.c > @@ -4,7 +4,7 @@ > =C2=A0 */ > =C2=A0 > =C2=A0#include > -#include > +#include > =C2=A0#include > =C2=A0#include > =C2=A0#include > @@ -49,6 +49,31 @@ static int vs_gem_dumb_create(struct drm_file > *file_priv, > =C2=A0 > =C2=A0DEFINE_DRM_GEM_FOPS(vs_drm_driver_fops); > =C2=A0 > +static struct drm_gem_object *vs_gem_create_object(struct drm_device > *drm, > + =C2=A0=C2=A0 size_t size) > +{ > + struct drm_gem_dma_object *obj; > + > + obj =3D kzalloc_obj(*obj); > + if (!obj) > + return ERR_PTR(-ENOMEM); > + > + obj->map_noncoherent =3D to_vs_drm_dev(drm)->noncoherent; > + > + return &obj->base; > +} > + > +static struct drm_framebuffer * > +vs_gem_fb_create(struct drm_device *drm, struct drm_file *file, > + const struct drm_format_info *info, > + const struct drm_mode_fb_cmd2 *mode_cmd) > +{ > + if (to_vs_drm_dev(drm)->noncoherent) > + return drm_gem_fb_create_with_dirty(drm, file, info, > mode_cmd); > + > + return drm_gem_fb_create(drm, file, info, mode_cmd); > +} > + > =C2=A0static const struct drm_driver vs_drm_driver =3D { > =C2=A0 .driver_features =3D DRIVER_MODESET | DRIVER_GEM | > DRIVER_ATOMIC, > =C2=A0 .fops =3D &vs_drm_driver_fops, > @@ -58,12 +83,13 @@ static const struct drm_driver vs_drm_driver =3D { > =C2=A0 .minor =3D DRIVER_MINOR, > =C2=A0 > =C2=A0 /* GEM Operations */ > + .gem_create_object =3D vs_gem_create_object, > =C2=A0 DRM_GEM_DMA_DRIVER_OPS_WITH_DUMB_CREATE(vs_gem_dumb_create), > =C2=A0 DRM_FBDEV_DMA_DRIVER_OPS, > =C2=A0}; > =C2=A0 > =C2=A0static const struct drm_mode_config_funcs vs_mode_config_funcs =3D = { > - .fb_create =3D drm_gem_fb_create, > + .fb_create =3D vs_gem_fb_create, > =C2=A0 .atomic_check =3D drm_atomic_helper_check, > =C2=A0 .atomic_commit =3D drm_atomic_helper_commit, > =C2=A0}; > @@ -98,6 +124,7 @@ int vs_drm_initialize(struct vs_dc *dc, struct > platform_device *pdev) > =C2=A0 > =C2=A0 drm =3D &vdrm->base; > =C2=A0 vdrm->dc =3D dc; > + vdrm->noncoherent =3D !of_dma_is_coherent(dev->of_node); > =C2=A0 dc->drm_dev =3D vdrm; > =C2=A0 > =C2=A0 ret =3D drmm_mode_config_init(drm); > diff --git a/drivers/gpu/drm/verisilicon/vs_drm.h > b/drivers/gpu/drm/verisilicon/vs_drm.h > index 606338206a42..17704cd0df1d 100644 > --- a/drivers/gpu/drm/verisilicon/vs_drm.h > +++ b/drivers/gpu/drm/verisilicon/vs_drm.h > @@ -18,8 +18,15 @@ struct vs_drm_dev { > =C2=A0 > =C2=A0 struct vs_dc *dc; > =C2=A0 struct vs_crtc *crtcs[VSDC_MAX_OUTPUTS]; > + > + bool noncoherent; > =C2=A0}; > =C2=A0 > +static inline struct vs_drm_dev *to_vs_drm_dev(struct drm_device > *drm) > +{ > + return container_of(drm, struct vs_drm_dev, base); > +} > + > =C2=A0int vs_drm_initialize(struct vs_dc *dc, struct platform_device > *pdev); > =C2=A0void vs_drm_finalize(struct vs_dc *dc); > =C2=A0void vs_drm_shutdown_handler(struct vs_dc *dc); > diff --git a/drivers/gpu/drm/verisilicon/vs_primary_plane.c > b/drivers/gpu/drm/verisilicon/vs_primary_plane.c > index e8fcb5958615..0049737f492b 100644 > --- a/drivers/gpu/drm/verisilicon/vs_primary_plane.c > +++ b/drivers/gpu/drm/verisilicon/vs_primary_plane.c > @@ -8,6 +8,7 @@ > =C2=A0#include > =C2=A0#include > =C2=A0#include > +#include > =C2=A0#include > =C2=A0#include > =C2=A0#include > @@ -16,8 +17,9 @@ > =C2=A0#include > =C2=A0 > =C2=A0#include "vs_crtc.h" > -#include "vs_plane.h" > =C2=A0#include "vs_dc.h" > +#include "vs_drm.h" > +#include "vs_plane.h" > =C2=A0#include "vs_primary_plane_regs.h" > =C2=A0 > =C2=A0static int vs_primary_plane_atomic_check(struct drm_plane *plane, > @@ -86,6 +88,8 @@ static void vs_primary_plane_atomic_disable(struct > drm_plane *plane, > =C2=A0static void vs_primary_plane_atomic_update(struct drm_plane *plane, > =C2=A0 =C2=A0=C2=A0 struct drm_atomic_state > *atomic_state) > =C2=A0{ > + struct drm_plane_state *old_state =3D > drm_atomic_get_old_plane_state(atomic_state, > + =09 > =C2=A0=C2=A0 plane); > =C2=A0 struct drm_plane_state *state =3D > drm_atomic_get_new_plane_state(atomic_state, > =C2=A0 =C2=A0=C2=A0=C2=A0=C2=A0 > =C2=A0=C2=A0 plane); > =C2=A0 struct drm_framebuffer *fb =3D state->fb; > @@ -101,6 +105,8 @@ static void vs_primary_plane_atomic_update(struct > drm_plane *plane, > =C2=A0 return; > =C2=A0 } > =C2=A0 > + drm_fb_dma_sync_non_coherent(plane->dev, old_state, state); > + > =C2=A0 vcrtc =3D drm_crtc_to_vs_crtc(crtc); > =C2=A0 output =3D vcrtc->id; > =C2=A0 dc =3D vcrtc->dc; > @@ -169,5 +175,8 @@ struct drm_plane *vs_primary_plane_init(struct > drm_device *drm_dev, struct vs_dc > =C2=A0 > =C2=A0 drm_plane_helper_add(plane, &vs_primary_plane_helper_funcs); > =C2=A0 > + if (to_vs_drm_dev(drm_dev)->noncoherent) > + drm_plane_enable_fb_damage_clips(plane); > + > =C2=A0 return plane; > =C2=A0}