From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756001AbcARQxe (ORCPT ); Mon, 18 Jan 2016 11:53:34 -0500 Received: from mail-pa0-f50.google.com ([209.85.220.50]:35948 "EHLO mail-pa0-f50.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755750AbcARQxb (ORCPT ); Mon, 18 Jan 2016 11:53:31 -0500 From: Jaewon Kim To: linux-kernel@vger.kernel.org Cc: Jaewon Kim Subject: [RFC] ratelimit: fix time interval by setting right start time Date: Tue, 19 Jan 2016 01:53:15 +0900 Message-Id: <1453135995-27374-1-git-send-email-jaewon31.kim@gmail.com> X-Mailer: git-send-email 1.9.1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org rs->begin should be initialized to the current jiffies if the begin was 0. Even when the time interval passes, the current resetting logic sets the begin back to 0. So next interval starts from the next call rather than from the current resetting call. This incurrs improper suppression. For example: B will be suppressed althouth 3 seconds passed. DEFINE_RATELIMIT_STATE(limit, HZ, 1); __ratelimit(&limit); /* A */ sleep(3); __ratelimit(&limit); /* B */ Signed-off-by: Jaewon Kim --- lib/ratelimit.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/ratelimit.c b/lib/ratelimit.c index 40e03ea..2c5de86 100644 --- a/lib/ratelimit.c +++ b/lib/ratelimit.c @@ -49,7 +49,7 @@ int ___ratelimit(struct ratelimit_state *rs, const char *func) if (rs->missed) printk(KERN_WARNING "%s: %d callbacks suppressed\n", func, rs->missed); - rs->begin = 0; + rs->begin = jiffies; rs->printed = 0; rs->missed = 0; } -- 1.9.1