From: Chen Feng <puck.chen@hisilicon.com>
To: <puck.chen@hisilicon.com>, <gregkh@linuxfoundation.org>,
<arve@android.com>, <riandrews@android.com>,
<devel@driverdev.osuosl.org>, <linux-kernel@vger.kernel.org>,
<yudongbin@hisilicon.com>, <saberlily.xia@hisilicon.com>,
<suzhuangluan@hisilicon.com>, <kong.kongxinwei@hisilicon.com>,
<xuyiping@hisilicon.com>, <z.liuxinliang@hisilicon.com>,
<weidong2@hisilicon.com>, <w.f@huawei.com>,
<puck.chen@foxmail.com>, <shimingxing@hisilicon.com>,
<oliver.fu@hisilicon.com>, <albert.lubing@hisilicon.com>,
<chenxiang9@huawei.com>, <liuzixing@huawei.com>,
<haojian.zhuang@linaro.org>, <zhaojunmin@huawei.com>,
<wangjing6@huawei.com>, <rientjes@google.com>,
<john.stultz@linaro.org>
Cc: <qijiwen@hisilicon.com>, <peter.panshilin@hisilicon.com>,
<dan.zhao@hisilicon.com>, <linuxarm@huawei.com>,
<dev@lists.96boards.org>
Subject: [PATCH RESEND] android: binder: Sanity check at binder ioctl
Date: Tue, 19 Jan 2016 11:45:36 +0800 [thread overview]
Message-ID: <1453175136-3351-1-git-send-email-puck.chen@hisilicon.com> (raw)
When a process fork a child process, we should not allow the
child process use the binder which opened by parent process.
But if the binder-object creater is a thread of one process who exit,
the other thread can also use this binder-object normally.
We can distinguish this by the member proc->tsk->mm.
If the thread exit the tsk->mm will be NULL.
proc->tsk->mm != current->mm && proc->tsk->mm
So only allow the shared mm_struct to use the same binder-object and
check the existence of mm_struct.
Signed-off-by: Chen Feng <puck.chen@hisilicon.com>
Signed-off-by: Wei Dong <weidong2@hisilicon.com>
Signed-off-by: Junmin Zhao <zhaojunmin@huawei.com>
Reviewed-by: Zhuangluan Su <suzhuangluan@hisilicon.com>
---
drivers/android/binder.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/android/binder.c b/drivers/android/binder.c
index a39e85f..279063c 100644
--- a/drivers/android/binder.c
+++ b/drivers/android/binder.c
@@ -2736,6 +2736,8 @@ static long binder_ioctl(struct file *filp, unsigned int cmd, unsigned long arg)
/*pr_info("binder_ioctl: %d:%d %x %lx\n",
proc->pid, current->pid, cmd, arg);*/
+ if (unlikely(proc->tsk->mm != current->mm && proc->tsk->mm))
+ return -EINVAL;
trace_binder_ioctl(cmd, arg);
--
1.9.1
next reply other threads:[~2016-01-19 3:50 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-19 3:45 Chen Feng [this message]
2016-01-19 7:33 ` Greg KH
2016-01-19 7:49 ` chenfeng
2016-01-19 8:35 ` Greg KH
2016-01-19 8:56 ` chenfeng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1453175136-3351-1-git-send-email-puck.chen@hisilicon.com \
--to=puck.chen@hisilicon.com \
--cc=albert.lubing@hisilicon.com \
--cc=arve@android.com \
--cc=chenxiang9@huawei.com \
--cc=dan.zhao@hisilicon.com \
--cc=dev@lists.96boards.org \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=haojian.zhuang@linaro.org \
--cc=john.stultz@linaro.org \
--cc=kong.kongxinwei@hisilicon.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxarm@huawei.com \
--cc=liuzixing@huawei.com \
--cc=oliver.fu@hisilicon.com \
--cc=peter.panshilin@hisilicon.com \
--cc=puck.chen@foxmail.com \
--cc=qijiwen@hisilicon.com \
--cc=riandrews@android.com \
--cc=rientjes@google.com \
--cc=saberlily.xia@hisilicon.com \
--cc=shimingxing@hisilicon.com \
--cc=suzhuangluan@hisilicon.com \
--cc=w.f@huawei.com \
--cc=wangjing6@huawei.com \
--cc=weidong2@hisilicon.com \
--cc=xuyiping@hisilicon.com \
--cc=yudongbin@hisilicon.com \
--cc=z.liuxinliang@hisilicon.com \
--cc=zhaojunmin@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®