From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755344AbcASOZw (ORCPT ); Tue, 19 Jan 2016 09:25:52 -0500 Received: from mga04.intel.com ([192.55.52.120]:58184 "EHLO mga04.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754557AbcASOZj (ORCPT ); Tue, 19 Jan 2016 09:25:39 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.22,317,1449561600"; d="scan'208";a="896482937" From: Matthew Wilcox To: Andrew Morton , Johannes Weiner Cc: Matthew Wilcox , "Kirill A. Shutemov" , Ross Zwisler , linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org Subject: [PATCH 4/8] radix_tree: Convert some variables to unsigned types Date: Tue, 19 Jan 2016 09:25:29 -0500 Message-Id: <1453213533-6040-5-git-send-email-matthew.r.wilcox@intel.com> X-Mailer: git-send-email 2.7.0.rc3 In-Reply-To: <1453213533-6040-1-git-send-email-matthew.r.wilcox@intel.com> References: <1453213533-6040-1-git-send-email-matthew.r.wilcox@intel.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Matthew Wilcox None of these can ever be negative, and it removes a few -Wsign-compare warnings. Signed-off-by: Matthew Wilcox --- lib/radix-tree.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/lib/radix-tree.c b/lib/radix-tree.c index 357b556..7a984ad 100644 --- a/lib/radix-tree.c +++ b/lib/radix-tree.c @@ -64,7 +64,7 @@ static struct kmem_cache *radix_tree_node_cachep; * Per-cpu pool of preloaded nodes */ struct radix_tree_preload { - int nr; + unsigned nr; /* nodes->private_data points to next preallocated node */ struct radix_tree_node *nodes; }; @@ -130,7 +130,7 @@ static inline int root_tag_get(struct radix_tree_root *root, unsigned int tag) */ static inline int any_tag_set(struct radix_tree_node *node, unsigned int tag) { - int idx; + unsigned idx; for (idx = 0; idx < RADIX_TREE_TAG_LONGS; idx++) { if (node->tags[tag][idx]) return 1; @@ -1453,7 +1453,7 @@ static __init unsigned long __maxindex(unsigned int height) if (shift < 0) return ~0UL; - if (shift >= BITS_PER_LONG) + if ((unsigned)shift >= BITS_PER_LONG) return 0UL; return ~0UL >> shift; } -- 2.7.0.rc3