From: "João Paulo Rechi Vita" <jprvita@gmail.com>
To: johannes@sipsolutions.net
Cc: marcel@holtmann.org, linux-wireless@vger.kernel.org,
davem@davemloft.net, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, jprvita@endlessm.com,
linux@endlessm.com
Subject: [PATCH 1/8] rfkill: Documentation and style fixes
Date: Tue, 19 Jan 2016 10:42:36 -0500 [thread overview]
Message-ID: <1453218163-31998-2-git-send-email-jprvita@endlessm.com> (raw)
In-Reply-To: <1453218163-31998-1-git-send-email-jprvita@endlessm.com>
Fixes some small typos, punctuation, and copy & paste issues. Also
removes an extra blank line.
Signed-off-by: João Paulo Rechi Vita <jprvita@endlessm.com>
---
include/linux/rfkill.h | 7 ++++---
net/rfkill/core.c | 5 ++---
2 files changed, 6 insertions(+), 6 deletions(-)
diff --git a/include/linux/rfkill.h b/include/linux/rfkill.h
index d901078..3dcbaf6 100644
--- a/include/linux/rfkill.h
+++ b/include/linux/rfkill.h
@@ -104,16 +104,17 @@ int __must_check rfkill_register(struct rfkill *rfkill);
*
* Pause polling -- say transmitter is off for other reasons.
* NOTE: not necessary for suspend/resume -- in that case the
- * core stops polling anyway
+ * core stops polling anyway.
*/
void rfkill_pause_polling(struct rfkill *rfkill);
/**
* rfkill_resume_polling(struct rfkill *rfkill)
*
- * Pause polling -- say transmitter is off for other reasons.
+ * Resume polling previously paused with rfkill_pause_polling.
* NOTE: not necessary for suspend/resume -- in that case the
- * core stops polling anyway
+ * core restarts polling anyway, even if was explicitly paused
+ * before suspending.
*/
void rfkill_resume_polling(struct rfkill *rfkill);
diff --git a/net/rfkill/core.c b/net/rfkill/core.c
index f53bf3b6..4d6d726 100644
--- a/net/rfkill/core.c
+++ b/net/rfkill/core.c
@@ -303,8 +303,8 @@ static void rfkill_set_block(struct rfkill *rfkill, bool blocked)
spin_lock_irqsave(&rfkill->lock, flags);
if (err) {
/*
- * Failed -- reset status to _prev, this may be different
- * from what set set _PREV to earlier in this function
+ * Failed -- reset status to _PREV. This may be different
+ * from what we have set _PREV to earlier in this function
* if rfkill_set_sw_state was invoked.
*/
if (rfkill->state & RFKILL_BLOCK_SW_PREV)
@@ -477,7 +477,6 @@ bool rfkill_get_global_sw_state(const enum rfkill_type type)
}
#endif
-
bool rfkill_set_hw_state(struct rfkill *rfkill, bool blocked)
{
bool ret, change;
--
2.5.0
next prev parent reply other threads:[~2016-01-19 15:44 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-19 15:42 [PATCH 0/8] General RFKill improvements João Paulo Rechi Vita
2016-01-19 15:42 ` João Paulo Rechi Vita [this message]
2016-01-19 20:11 ` [PATCH 1/8] rfkill: Documentation and style fixes Johannes Berg
2016-01-19 20:19 ` João Paulo Rechi Vita
2016-01-19 15:42 ` [PATCH 2/8] rfkill: Improve code readability João Paulo Rechi Vita
2016-01-19 15:42 ` [PATCH 3/8] " João Paulo Rechi Vita
2016-01-19 15:42 ` [PATCH 4/8] rfkill: Remove obsolete "claim" sysfs interface João Paulo Rechi Vita
2016-01-19 15:42 ` [PATCH 5/8] rfkill: Remove obsolete "state" " João Paulo Rechi Vita
2016-01-19 20:15 ` Johannes Berg
2016-01-19 20:36 ` João Paulo Rechi Vita
2016-01-19 20:44 ` Johannes Berg
2016-01-19 15:42 ` [PATCH 6/8] rfkill: Move user_state_from_blocked() close to its user João Paulo Rechi Vita
2016-01-19 15:42 ` [PATCH 7/8] rfkill: Update userspace API documentation João Paulo Rechi Vita
2016-01-19 15:42 ` [PATCH 8/8] rfkill: Factor common code João Paulo Rechi Vita
2016-01-19 17:39 ` kbuild test robot
2016-01-19 20:32 ` João Paulo Rechi Vita
2016-01-19 18:15 ` kbuild test robot
2016-01-26 13:08 ` [PATCH 0/8] General RFKill improvements Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1453218163-31998-2-git-send-email-jprvita@endlessm.com \
--to=jprvita@gmail.com \
--cc=davem@davemloft.net \
--cc=johannes@sipsolutions.net \
--cc=jprvita@endlessm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=linux@endlessm.com \
--cc=marcel@holtmann.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®