From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933733AbcATMgg (ORCPT ); Wed, 20 Jan 2016 07:36:36 -0500 Received: from mail-pf0-f173.google.com ([209.85.192.173]:36734 "EHLO mail-pf0-f173.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933514AbcATMgL (ORCPT ); Wed, 20 Jan 2016 07:36:11 -0500 From: Sudip Mukherjee To: Andrew Morton Cc: linux-kernel@vger.kernel.org, reiserfs-devel@vger.kernel.org, Sudip Mukherjee Subject: [PATCH] reiserfs: fix dereference of ERR_PTR Date: Wed, 20 Jan 2016 18:06:02 +0530 Message-Id: <1453293362-22893-1-git-send-email-sudipm.mukherjee@gmail.com> X-Mailer: git-send-email 1.9.1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org reiserfs_iget() returns either NULL or error code in ERR_PTR. And we were only checking for NULL, so in case of some other error we will try to dereference the ERR_PTR(-errno) thinking it to be a valid pointer. Signed-off-by: Sudip Mukherjee --- fs/reiserfs/super.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/reiserfs/super.c b/fs/reiserfs/super.c index 05db747..c0306ec 100644 --- a/fs/reiserfs/super.c +++ b/fs/reiserfs/super.c @@ -288,7 +288,7 @@ static int finish_unfinished(struct super_block *s) pathrelse(&path); inode = reiserfs_iget(s, &obj_key); - if (!inode) { + if (IS_ERR_OR_NULL(inode)) { /* * the unlink almost completed, it just did not * manage to remove "save" link and release objectid -- 1.9.1