From: Joe Perches <joe@perches.com>
To: Bhumika Goyal <bhumirks@gmail.com>,
oleg.drokin@intel.com, gregkh@linuxfoundation.org
Cc: andreas.dilger@intel.com, linux-kernel@vger.kernel.org,
devel@driverdev.osuosl.org, lustre-devel@lists.lustre.org
Subject: Re: [PATCH 1/2] Staging:lustre:obdclass:linux:remove unnecessary braces
Date: Wed, 20 Jan 2016 11:06:26 -0800 [thread overview]
Message-ID: <1453316786.22381.5.camel@perches.com> (raw)
In-Reply-To: <15c9918abc5b46042246d7a5e82d595137be7daa.1453313907.git.bhumirks@gmail.com>
On Thu, 2016-01-21 at 00:17 +0530, Bhumika Goyal wrote:
> Fixed 'braces {} are not necessary for single statement blocks'
> checkpatch.pl warning.
[]
> diff --git a/drivers/staging/lustre/lustre/obdclass/linux/linux-module.c b/drivers/staging/lustre/lustre/obdclass/linux/linux-module.c
[]
> @@ -144,9 +144,8 @@ int obd_ioctl_getdata(char **buf, int *len, void *arg)
> offset += cfs_size_round(data->ioc_inllen3);
> }
>
> - if (data->ioc_inllen4) {
> + if (data->ioc_inllen4)
> data->ioc_inlbuf4 = &data->ioc_bulk[0] + offset;
You might also consider converting uses of &foo[0] to foo
next prev parent reply other threads:[~2016-01-20 19:06 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-20 18:47 [PATCH 0/2]Staging:lustre:obdclass:linux:fix checkpatch.pl warnings Bhumika Goyal
2016-01-20 18:47 ` [PATCH 1/2] Staging:lustre:obdclass:linux:remove unnecessary braces Bhumika Goyal
2016-01-20 19:06 ` Joe Perches [this message]
2016-01-20 18:47 ` [PATCH 2/2] Staging:lustre:obdclass:linux:simplify NULL comparison Bhumika Goyal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1453316786.22381.5.camel@perches.com \
--to=joe@perches.com \
--cc=andreas.dilger@intel.com \
--cc=bhumirks@gmail.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lustre-devel@lists.lustre.org \
--cc=oleg.drokin@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome