mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Mimi Zohar <zohar@linux.vnet.ibm.com>
To: Colin King <colin.king@canonical.com>
Cc: Dmitry Kasatkin <dmitry.kasatkin@gmail.com>,
	James Morris <james.l.morris@oracle.com>,
	"Serge E . Hallyn" <serge@hallyn.com>,
	linux-ima-devel@lists.sourceforge.net,
	linux-ima-user@lists.sourceforge.net,
	linux-security-module@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] IMA: fix non-ANSI declaration of ima_check_policy()
Date: Thu, 21 Jan 2016 08:21:51 -0500	[thread overview]
Message-ID: <1453382511.9549.140.camel@linux.vnet.ibm.com> (raw)
In-Reply-To: <1453288426-4011-1-git-send-email-colin.king@canonical.com>

On Wed, 2016-01-20 at 11:13 +0000, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
> 
> ima_check_policy() has no parameters, so use the normal void
> parameter convention to make it match the prototype in the header file
> security/integrity/ima/ima.h
> 
> Signed-off-by: Colin Ian King <colin.king@canonical.com>

Thank you.

Mimi

> ---
>  security/integrity/ima/ima_policy.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/security/integrity/ima/ima_policy.c b/security/integrity/ima/ima_policy.c
> index 0a3b781..e0e18cc 100644
> --- a/security/integrity/ima/ima_policy.c
> +++ b/security/integrity/ima/ima_policy.c
> @@ -417,7 +417,7 @@ void __init ima_init_policy(void)
>  }
> 
>  /* Make sure we have a valid policy, at least containing some rules. */
> -int ima_check_policy()
> +int ima_check_policy(void)
>  {
>  	if (list_empty(&ima_temp_rules))
>  		return -EINVAL;

      reply	other threads:[~2016-01-21 13:22 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-01-20 11:13 Colin King
2016-01-21 13:21 ` Mimi Zohar [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1453382511.9549.140.camel@linux.vnet.ibm.com \
    --to=zohar@linux.vnet.ibm.com \
    --cc=colin.king@canonical.com \
    --cc=dmitry.kasatkin@gmail.com \
    --cc=james.l.morris@oracle.com \
    --cc=linux-ima-devel@lists.sourceforge.net \
    --cc=linux-ima-user@lists.sourceforge.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-security-module@vger.kernel.org \
    --cc=serge@hallyn.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome