From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759615AbcAUNys (ORCPT ); Thu, 21 Jan 2016 08:54:48 -0500 Received: from out3-smtp.messagingengine.com ([66.111.4.27]:57421 "EHLO out3-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1759002AbcAUNyo (ORCPT ); Thu, 21 Jan 2016 08:54:44 -0500 Message-Id: <1453384483.1258747.498568498.27762FC4@webmail.messagingengine.com> X-Sasl-Enc: z3N0QhBU/2kzsmU0dTtY6caNO3/JXCiJxmkd9JbMk3xB 1453384483 From: Henrique de Moraes Holschuh To: Eric Curtin , platform-driver-x86@vger.kernel.org Cc: ibm-acpi-devel@lists.sourceforge.net, Darren Hart , ibm-acpi@hmh.eng.br, Kernel development list MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Type: text/plain X-Mailer: MessagingEngine.com Webmail Interface - ajax-6cda141f In-Reply-To: References: Subject: Re: [PATCH] Remove logging for "Unsupported brightness interface" Date: Thu, 21 Jan 2016 11:54:43 -0200 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jan 21, 2016, at 09:18, Eric Curtin wrote: > On 16 January 2016 at 23:43, Eric Curtin wrote: > > Message gets logged on machines that are well supported. > > Fixed one checkpatch.pl ERROR also. > > > > Signed-off-by: Eric Curtin > > --- > > drivers/platform/x86/thinkpad_acpi.c | 6 ++---- > > 1 file changed, 2 insertions(+), 4 deletions(-) > > > > diff --git a/drivers/platform/x86/thinkpad_acpi.c > > b/drivers/platform/x86/thinkpad_acpi.c > > index 0bed473..b149dec 100644 > > --- a/drivers/platform/x86/thinkpad_acpi.c > > +++ b/drivers/platform/x86/thinkpad_acpi.c > > @@ -6434,7 +6434,7 @@ static const struct tpacpi_quirk > > brightness_quirk_table[] __initconst = { > > */ > > static void __init tpacpi_detect_brightness_capabilities(void) > > { > > - unsigned int b; > > + const unsigned int b = tpacpi_check_std_acpi_brightness_support(); This unrelated change can have side-effects, and I didn't stop to look at the code yet to know if it is desired. Regardless, it should be in a separate patch anyway as it has nothing to do with the removal of the log message, so please drop it. -- "One disk to rule them all, One disk to find them. One disk to bring them all and in the darkness grind them. In the Land of Redmond where the shadows lie." -- The Silicon Valley Tarot Henrique Holschuh