From: "Bryan O'Donoghue" <pure.logic@nexus-software.ie>
To: x86@kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org
Cc: "Bryan O'Donoghue" <pure.logic@nexus-software.ie>
Subject: [PATCH] x86/intel/quark: Remove lock bit around kernel IMR
Date: Thu, 21 Jan 2016 14:05:13 +0000 [thread overview]
Message-ID: <1453385113-23034-1-git-send-email-pure.logic@nexus-software.ie> (raw)
Currently when setting up an IMR around the kernel .text area we lock that
IMR, preventing further modification. While superficially this appears to
be the right thing to do, in fact this doesn't account for a legitimate
change in the memory map such as when running through kexec. In such a
scenario a second kernel can have a different size and location to it's
predecessor and can view some of the memory occupied by its predecessor as
legitimately usable RAM. This RAM can then be allocated to DMA agents
within the system and trigger an IMR violation.
The solution to this situation is to keep the kernel .text section IMR lock
bit false. This means that a subsequent kernel will boot and can tear-down
an existing IMR, while still setting up an IMR around its own .text
section.
Signed-off-by: Bryan O'Donoghue <pure.logic@nexus-software.ie>
Reported-by: Andriy Shevchenko <andriy.shevchenko@intel.com>
---
arch/x86/platform/intel-quark/imr.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/x86/platform/intel-quark/imr.c b/arch/x86/platform/intel-quark/imr.c
index c1bdafa..1c43639 100644
--- a/arch/x86/platform/intel-quark/imr.c
+++ b/arch/x86/platform/intel-quark/imr.c
@@ -591,7 +591,7 @@ static void __init imr_fixup_memmap(struct imr_device *idev)
* from the beginning of the .text secton to the end of the
* .rodata section as one physically contiguous block.
*/
- ret = imr_add_range(base, size, IMR_CPU, IMR_CPU, true);
+ ret = imr_add_range(base, size, IMR_CPU, IMR_CPU, false);
if (ret < 0) {
pr_err("unable to setup IMR for kernel: (%p - %p)\n",
&_text, &__end_rodata);
--
2.5.0
next reply other threads:[~2016-01-21 14:14 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-21 14:05 Bryan O'Donoghue [this message]
2016-01-21 18:44 ` Andy Shevchenko
2016-01-22 11:08 ` Bryan O'Donoghue
2016-01-22 12:11 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1453385113-23034-1-git-send-email-pure.logic@nexus-software.ie \
--to=pure.logic@nexus-software.ie \
--cc=linux-kernel@vger.kernel.org \
--cc=stable@vger.kernel.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®