mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Caesar Wang <wxt@rock-chips.com>
To: Heiko Stuebner <heiko@sntech.de>, Vinod Koul <vinod.koul@intel.com>
Cc: Sonny Rao <sonnyrao@chromium.org>,
	shawn.lin@rock-chips.com, dianders@chromium.org,
	linux-rockchip@lists.infradead.org,
	Addy Ke <addy.ke@rock-chips.com>, Olof Johansson <olof@lixom.net>,
	Caesar Wang <wxt@rock-chips.com>, Mark Brown <broonie@kernel.org>,
	linux-kernel@vger.kernel.org, linux-spi@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org
Subject: [PATCH v7 9/9] spi: rockchip: modify DMA max burst to 1
Date: Fri, 22 Jan 2016 19:06:52 +0800	[thread overview]
Message-ID: <1453460812-8498-10-git-send-email-wxt@rock-chips.com> (raw)
In-Reply-To: <1453460812-8498-1-git-send-email-wxt@rock-chips.com>

From: Addy Ke <addy.ke@rock-chips.com>

Generic dma controller on Rockchips' platform cannot support
DMAFLUSHP instruction which make dma to flush the req of non-aligned
or non-multiple of what we need. That will cause an unrecoverable
dma bus error. The saftest way is to set dma max burst to 1.

Signed-off-by: Addy ke <addy.ke@rock-chips.com>
Fixes: 64e36824b32b06 ("spi/rockchip: add driver for Rockchip...")
Signed-off-by: Shawn Lin <shawn.lin@rock-chips.com>
cc: Heiko Stuebner <heiko@sntech.de>
cc: Olof Johansson <olof@lixom.net>
cc: Doug Anderson <dianders@chromium.org>
cc: Sonny Rao <sonnyrao@chromium.org>

Acked-by: Mark Brown <broonie@kernel.org>
Signed-off-by: Caesar Wang <wxt@rock-chips.com>

---

Changes in v7: None
Changes in v6:
- remove quirks and get dma caps in order to limit burst

Changes in v5: None
Changes in v4: None
Changes in v3: None
Changes in v2: None
Changes in v1: None

 drivers/spi/spi-rockchip.c | 12 ++++++++++--
 1 file changed, 10 insertions(+), 2 deletions(-)

diff --git a/drivers/spi/spi-rockchip.c b/drivers/spi/spi-rockchip.c
index 79a8bc4..aa9561f 100644
--- a/drivers/spi/spi-rockchip.c
+++ b/drivers/spi/spi-rockchip.c
@@ -199,6 +199,7 @@ struct rockchip_spi {
 	struct sg_table rx_sg;
 	struct rockchip_spi_dma_data dma_rx;
 	struct rockchip_spi_dma_data dma_tx;
+	struct dma_slave_caps dma_caps;
 };
 
 static inline void spi_enable_chip(struct rockchip_spi *rs, int enable)
@@ -449,7 +450,10 @@ static void rockchip_spi_prepare_dma(struct rockchip_spi *rs)
 		rxconf.direction = rs->dma_rx.direction;
 		rxconf.src_addr = rs->dma_rx.addr;
 		rxconf.src_addr_width = rs->n_bytes;
-		rxconf.src_maxburst = rs->n_bytes;
+		if (rs->dma_caps.max_burst > 4)
+			rxconf.src_maxburst = 4;
+		else
+			rxconf.src_maxburst = 1;
 		dmaengine_slave_config(rs->dma_rx.ch, &rxconf);
 
 		rxdesc = dmaengine_prep_slave_sg(
@@ -466,7 +470,10 @@ static void rockchip_spi_prepare_dma(struct rockchip_spi *rs)
 		txconf.direction = rs->dma_tx.direction;
 		txconf.dst_addr = rs->dma_tx.addr;
 		txconf.dst_addr_width = rs->n_bytes;
-		txconf.dst_maxburst = rs->n_bytes;
+		if (rs->dma_caps.max_burst > 4)
+			txconf.dst_maxburst = 4;
+		else
+			txconf.dst_maxburst = 1;
 		dmaengine_slave_config(rs->dma_tx.ch, &txconf);
 
 		txdesc = dmaengine_prep_slave_sg(
@@ -730,6 +737,7 @@ static int rockchip_spi_probe(struct platform_device *pdev)
 	}
 
 	if (rs->dma_tx.ch && rs->dma_rx.ch) {
+		dma_get_slave_caps(rs->dma_rx.ch, &(rs->dma_caps));
 		rs->dma_tx.addr = (dma_addr_t)(mem->start + ROCKCHIP_SPI_TXDR);
 		rs->dma_rx.addr = (dma_addr_t)(mem->start + ROCKCHIP_SPI_RXDR);
 		rs->dma_tx.direction = DMA_MEM_TO_DEV;
-- 
1.9.1

  parent reply	other threads:[~2016-01-22 11:08 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-01-22 11:06 [PATCH v7 0/9] Fix broken DMAFLUSHP on Rockchips platform Caesar Wang
2016-01-22 11:06 ` [PATCH v7 1/9] dmaengine: pl330: support burst mode for dev-to-mem and mem-to-dev transmit Caesar Wang
2016-02-09  3:32   ` Vinod Koul
2016-01-22 11:06 ` [PATCH v7 2/9] dt/bindings: arm-pl330: add description of arm, pl330-broken-no-flushp Caesar Wang
2016-01-22 22:29   ` Rob Herring
2016-02-09  3:32   ` Vinod Koul
2016-01-22 11:06 ` [PATCH v7 3/9] dmaengine: pl330: add quirk for broken no flushp Caesar Wang
2016-02-09  3:33   ` Vinod Koul
2016-01-22 11:06 ` [PATCH v7 4/9] ARM: dts: Add arm, pl330-broken-no-flushp quirk for rk3288 platform Caesar Wang
2016-01-22 11:06 ` [PATCH v7 5/9] ARM: dts: Add arm, pl330-broken-no-flushp quirk for rk3xxx platform Caesar Wang
2016-01-22 11:06 ` [PATCH v7 6/9] ARM: dts: add pl330-broken-no-flushp quirk for rk3036 SoCs Caesar Wang
2016-02-09 17:29   ` Heiko Stuebner
2016-01-22 11:06 ` [PATCH v7 7/9] dmaengine: core: expose max burst capability to clients Caesar Wang
2016-02-09  3:33   ` Vinod Koul
2016-01-22 11:06 ` [PATCH v7 8/9] dmaengine: pl330: add max burst for dmaengine Caesar Wang
2016-02-09  3:34   ` Vinod Koul
2016-01-22 11:06 ` Caesar Wang [this message]
2016-02-09  3:34   ` [PATCH v7 9/9] spi: rockchip: modify DMA max burst to 1 Vinod Koul
2016-02-01  6:56 ` [PATCH v7 0/9] Fix broken DMAFLUSHP on Rockchips platform Caesar Wang
2016-02-08  3:11   ` Vinod Koul
2016-02-08  9:27     ` Heiko Stuebner
2016-02-08 13:14       ` Vinod Koul
2016-02-08 14:02         ` Mark Brown
2016-02-08 22:21         ` Heiko Stuebner
2016-02-09  3:21           ` Vinod Koul

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1453460812-8498-10-git-send-email-wxt@rock-chips.com \
    --to=wxt@rock-chips.com \
    --cc=addy.ke@rock-chips.com \
    --cc=broonie@kernel.org \
    --cc=dianders@chromium.org \
    --cc=heiko@sntech.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rockchip@lists.infradead.org \
    --cc=linux-spi@vger.kernel.org \
    --cc=olof@lixom.net \
    --cc=shawn.lin@rock-chips.com \
    --cc=sonnyrao@chromium.org \
    --cc=vinod.koul@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®