From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753431AbcAVL6W (ORCPT ); Fri, 22 Jan 2016 06:58:22 -0500 Received: from mga03.intel.com ([134.134.136.65]:26619 "EHLO mga03.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753383AbcAVL6S (ORCPT ); Fri, 22 Jan 2016 06:58:18 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.22,330,1449561600"; d="scan'208";a="896031283" Message-ID: <1453463800.2521.189.camel@linux.intel.com> Subject: Re: [PATCH 1/3] ata: sata_dwc_460ex: use "dmas" DT property to find dma channel From: Andy Shevchenko To: =?ISO-8859-1?Q?M=E5ns_Rullg=E5rd?= Cc: Andy Shevchenko , Julian Margetson , Tejun Heo , linux-ide@vger.kernel.org, "linux-kernel@vger.kernel.org" Date: Fri, 22 Jan 2016 13:56:40 +0200 In-Reply-To: References: <1450221935-6034-1-git-send-email-mans@mansr.com> <1450724880.30729.250.camel@linux.intel.com> <1450731289.30729.282.camel@linux.intel.com> <1450781890.30729.298.camel@linux.intel.com> <1452159294.30729.405.camel@linux.intel.com> <1452243464.30729.430.camel@linux.intel.com> <1453317808.2521.135.camel@linux.intel.com> <1453457080.2521.179.camel@linux.intel.com> Organization: Intel Finland Oy Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.18.3-1 Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 2016-01-22 at 11:13 +0000, Måns Rullgård wrote: > Andy Shevchenko writes: > > On Wed, 2016-01-20 at 20:07 +0000, Måns Rullgård wrote: > > > Andy Shevchenko writes: > > In DWC_DEFAULT_CTLLO() can we do tab indentation for \ ? > > Is there a wrong indentation somewhere?  I don't see it. My git diff shows this in particular: --- a/drivers/dma/dw/core.c +++ b/drivers/dma/dw/core.c @@ -45,10 +45,10 @@                         DW_DMA_MSIZE_16;                        \                 u8 _dmsize = _is_slave ? _sconfig->dst_maxburst :       \                         DW_DMA_MSIZE_16;                        \ -               u8 _dms = (_is_slave && _dwc->direction == DMA_MEM_TO_DEV) ? \ -                       _dwc->p_master : _dwc- >m_master;                \ -               u8 _sms = (_is_slave && _dwc->direction == DMA_DEV_TO_MEM) ? \ -                       _dwc->p_master : _dwc- >m_master;                \ +               u8 _dms = (_is_slave && _dwc->direction == DMA_MEM_TO_DEV) ?    \ +                          _dwc->p_master : _dwc- >m_master;                     \ +               u8 _sms = (_is_slave && _dwc->direction == DMA_DEV_TO_MEM) ?    \ +                          _dwc->p_master : _dwc- >m_master;                     \ Means in your case the ' \' is used, in mine — '\t\' at the end of lines. > Now the question: who do you prefer to submit the series (dw_dmac)? > > Me > > or you? > > > > In case you would like to do it (what I see in your dwc-sata branch > > today): > > Acked-by: Andy Shevchenko > > I'll fix the above, give your changes a review, and add my sign-off > before sending the series, today or during the weekend. OK. Just to be sure we are on the same page. I assume your dwc-sata branch as for submitting. -- Andy Shevchenko Intel Finland Oy