From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755289AbcAVVpm (ORCPT ); Fri, 22 Jan 2016 16:45:42 -0500 Received: from youngberry.canonical.com ([91.189.89.112]:35511 "EHLO youngberry.canonical.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754475AbcAVVpC (ORCPT ); Fri, 22 Jan 2016 16:45:02 -0500 From: Chris J Arges To: jpoimboe@redhat.com, live-patching@vger.kernel.org, x86@kernel.org, pbonzini@redhat.com Cc: gleb@kernel.org, tglx@linutronix.de, mingo@redhat.com, hpa@zytor.com, kvm@vger.kernel.org, linux-kernel@vger.kernel.org, Chris J Arges Subject: [PATCH 1/2] tools/stacktool: Add __reiserfs_panic to global_noreturns list Date: Fri, 22 Jan 2016 15:44:37 -0600 Message-Id: <1453499078-9330-2-git-send-email-chris.j.arges@canonical.com> X-Mailer: git-send-email 2.7.0.rc3 In-Reply-To: <1453499078-9330-1-git-send-email-chris.j.arges@canonical.com> References: <20160122204744.GI20502@treble.redhat.com> <1453499078-9330-1-git-send-email-chris.j.arges@canonical.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The following false positives were noticed with stacktool: stacktool: fs/reiserfs/namei.o: set_de_name_and_namelen()+0x9e: return without frame pointer restore stacktool: fs/reiserfs/namei.o: set_de_name_and_namelen()+0x89: duplicate frame pointer save stacktool: fs/reiserfs/namei.o: set_de_name_and_namelen()+0x8a: duplicate frame pointer setup stacktool: fs/reiserfs/namei.o: set_de_name_and_namelen()+0x9e: frame pointer state mismatch stacktool: fs/reiserfs/namei.o: set_de_name_and_namelen()+0x0: frame pointer state mismatch These all call into '__reiserfs_panic' which has a noreturn attribute. Add this to the global list because this particular attribute cannot be determined from reading the ELF object. Signed-off-by: Chris J Arges --- tools/stacktool/builtin-check.c | 1 + 1 file changed, 1 insertion(+) diff --git a/tools/stacktool/builtin-check.c b/tools/stacktool/builtin-check.c index 5b0e91f..23fa93d2 100644 --- a/tools/stacktool/builtin-check.c +++ b/tools/stacktool/builtin-check.c @@ -139,6 +139,7 @@ static bool dead_end_function(struct stacktool_file *file, struct symbol *func) "__module_put_and_exit", "complete_and_exit", "kvm_spurious_fault", + "__reiserfs_panic", }; if (func->bind == STB_WEAK) -- 2.5.0