From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756818AbcAYKB1 (ORCPT ); Mon, 25 Jan 2016 05:01:27 -0500 Received: from metis.ext.4.pengutronix.de ([92.198.50.35]:42840 "EHLO metis.ext.4.pengutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756337AbcAYKBY (ORCPT ); Mon, 25 Jan 2016 05:01:24 -0500 Message-ID: <1453716080.2559.3.camel@pengutronix.de> Subject: Re: [PATCH] reset: hisilicon: check return value of reset_controller_register() From: Philipp Zabel To: Masahiro Yamada Cc: linux-kernel@vger.kernel.org, Arnd Bergmann , Chen Feng Date: Mon, 25 Jan 2016 11:01:20 +0100 In-Reply-To: <1453565997-1010-1-git-send-email-yamada.masahiro@socionext.com> References: <1453565997-1010-1-git-send-email-yamada.masahiro@socionext.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.12.9-1+b1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit X-SA-Exim-Connect-IP: 2001:67c:670:100:96de:80ff:fec2:9969 X-SA-Exim-Mail-From: p.zabel@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Am Sonntag, den 24.01.2016, 01:19 +0900 schrieb Masahiro Yamada: > The newly added hisilicon reset driver missed the subsystem-wide > fixup by commit d1f15aa09558 ("reset: check return value of > reset_controller_register()"). So fix it now. > > Signed-off-by: Masahiro Yamada > --- > > drivers/reset/hisilicon/hi6220_reset.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/drivers/reset/hisilicon/hi6220_reset.c b/drivers/reset/hisilicon/hi6220_reset.c > index 7787a9b..744b2e7 100644 > --- a/drivers/reset/hisilicon/hi6220_reset.c > +++ b/drivers/reset/hisilicon/hi6220_reset.c > @@ -83,9 +83,7 @@ static int hi6220_reset_probe(struct platform_device *pdev) > data->rc_dev.ops = &hi6220_reset_ops; > data->rc_dev.of_node = pdev->dev.of_node; > > - reset_controller_register(&data->rc_dev); > - > - return 0; > + return reset_controller_register(&data->rc_dev); > } > > static const struct of_device_id hi6220_reset_match[] = { Applied, thanks. regards Philipp