From: Joe Perches <joe@perches.com>
To: Sudip Mukherjee <sudipm.mukherjee@gmail.com>,
Patrick Pannuto <ppannuto@codeaurora.org>
Cc: Dan Carpenter <dan.carpenter@oracle.com>,
Willy Tarreau <willy@meta-x.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
devel@driverdev.osuosl.org,
Sirnam Swetha <theonly.ultimate@gmail.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Revert "Staging: panel: usleep_range is preferred over udelay"
Date: Mon, 25 Jan 2016 04:58:33 -0800 [thread overview]
Message-ID: <1453726713.28952.58.camel@perches.com> (raw)
In-Reply-To: <20160125125127.GB29998@sudip-pc>
On Mon, 2016-01-25 at 18:21 +0530, Sudip Mukherjee wrote:
> On Mon, Jan 25, 2016 at 04:47:26AM -0800, Joe Perches wrote:
> > On Mon, 2016-01-25 at 12:16 +0300, Dan Carpenter wrote:
> > > Ugh... Checkpatch told us to introduce bugs... :( We almost certainly
> > > would have missed this bug in review, but it wasn't sent to the list so
> > > I guess we'll never know.
> >
> > So when isn't usleep_range preferred over udelay?
>
> inside a spin_lock or in some interrupt routine.
That's what timers-howto says and the checkpatch message
for this refers to it.
This message has been in checkpatch since 2010
commit 1a15a250862fda3fbdf8454cc7131e24de904e7c
Author: Patrick Pannuto <ppannuto@codeaurora.org>
Maybe the checkpatch message can have "when not atomic"
added or some such.
prev parent reply other threads:[~2016-01-25 12:58 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-23 9:19 Sudip Mukherjee
2016-01-25 4:36 ` Sudip Mukherjee
2016-01-25 9:16 ` Dan Carpenter
2016-01-25 9:34 ` Dan Carpenter
2016-01-25 9:43 ` Sudip Mukherjee
2016-01-25 11:03 ` Dan Carpenter
2016-01-25 12:40 ` Dan Carpenter
2016-01-25 12:49 ` Sudip Mukherjee
2016-01-25 20:42 ` Willy Tarreau
2016-01-26 0:32 ` Huang, Ying
2016-01-26 1:36 ` Dan Carpenter
2016-01-26 2:01 ` Huang, Ying
2016-01-25 12:47 ` Joe Perches
2016-01-25 12:51 ` Sudip Mukherjee
2016-01-25 12:58 ` Joe Perches [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1453726713.28952.58.camel@perches.com \
--to=joe@perches.com \
--cc=dan.carpenter@oracle.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ppannuto@codeaurora.org \
--cc=sudipm.mukherjee@gmail.com \
--cc=theonly.ultimate@gmail.com \
--cc=willy@meta-x.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome