From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758031AbcAYRJi (ORCPT ); Mon, 25 Jan 2016 12:09:38 -0500 Received: from mail-pa0-f54.google.com ([209.85.220.54]:34206 "EHLO mail-pa0-f54.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758000AbcAYRJb (ORCPT ); Mon, 25 Jan 2016 12:09:31 -0500 Message-ID: <1453741769.11327.0.camel@edumazet-glaptop2.roam.corp.google.com> Subject: Re: [PATCH net-next] hv_netvsc: use skb_get_hash() instead of a homegrown implementation From: Eric Dumazet To: Vitaly Kuznetsov Cc: netdev@vger.kernel.org, "K. Y. Srinivasan" , Haiyang Zhang , linux-kernel@vger.kernel.org, devel@linuxdriverproject.org, David Miller , Tom Herbert , One Thousand Gnomes Date: Mon, 25 Jan 2016 09:09:29 -0800 In-Reply-To: <1453734041-20394-1-git-send-email-vkuznets@redhat.com> References: <1453734041-20394-1-git-send-email-vkuznets@redhat.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.10.4-0ubuntu2 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 2016-01-25 at 16:00 +0100, Vitaly Kuznetsov wrote: > Recent changes to 'struct flow_keys' (e.g commit d34af823ff40 ("net: Add > VLAN ID to flow_keys")) introduced a performance regression in netvsc > driver. Is problem is, however, not the above mentioned commit but the > fact that netvsc_set_hash() function did some assumptions on the struct > flow_keys data layout and this is wrong. > > Get rid of netvsc_set_hash() by switching to skb_get_hash(). This change > will also imply switching to Jenkins hash from the currently used Toeplitz > but it seems there is no good excuse for Toeplitz to stay. > > Signed-off-by: Vitaly Kuznetsov > --- Acked-by: Eric Dumazet Thanks !