mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Michal Malý" <madcatxster@devoid-pointer.net>
To: Jiri Kosina <jikos@kernel.org>
Cc: "Bjørn Mork" <bjorn@mork.no>,
	gregkh@linuxfoundation.org, linux-usb@vger.kernel.org,
	linux-kernel@vger.kernel.org, dmitry.torokhov@gmail.com,
	elias.vds@gmail.com, edwin@velds.nl, simon@mungewell.org
Subject: Re: [PATCH 0/2] Add a skeleton module to perform a basic initialization on certain USB devices
Date: Mon, 25 Jan 2016 22:02:31 +0100	[thread overview]
Message-ID: <1453755751.3994.2.camel@devoid-pointer.net> (raw)
In-Reply-To: <alpine.LNX.2.00.1601251511350.21446@cbobk.fhfr.pm>

On Mon, 2016-01-25 at 15:17 +0100, Jiri Kosina wrote:
> On Sat, 23 Jan 2016, Michal Malý wrote:
> 
> > I briefly considered leaving the switch up to the userspace and
> handling the 
> > device in the kernel only once it's been switched. I am however
> uncertain how 
> > to advertise this to the users. Writing a tiny app that would
> currently handle 
> > just one device seems like an overkill, abusing usb_modeswitch
> seems counter-
> > intuitive as it's purpose is to handle various USB modems. 
> 
> Well, originally usb_modeswitch (beware, it's called "modeswitch",
> not 
> "modemswitch" :) ) was purely for handling ZeroCD on USB 3G modems,
> and 
> it's currently still by far the most common case, but there are
> other 
> devices being handled by that package now; I for example recall some 
> HP printers needing a magic USB command to be sent to it before they
> would 
> start printing, and usb_modeswitch is handling those now AFAIK.
> 
> So if we do this in userspace, I think usb_modeswitch is not a bad
> choice.

Ok, that's interesting... I tinkered with usb_modeswitch a bit and I
made it switch the G920 just fine after a while. Consider the patches
dropped then, letting usb_modeswitch take care of this sounds
reasonable.

Michal

      reply	other threads:[~2016-01-25 21:02 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-01-23 10:35 Michal Malý
2016-01-23 10:35 ` [PATCH 1/2] Add usb_skelswitch skeleton module to do basic initialization of devices that at first appear as a generic USB device Michal Malý
2016-01-23 10:35 ` [PATCH 2/2] Use usb_skelswitch module to switch Logitech G920 Racing Wheel to HID mode Michal Malý
2016-01-23 12:46 ` [PATCH 0/2] Add a skeleton module to perform a basic initialization on certain USB devices Bjørn Mork
2016-01-23 15:56   ` Michal Malý
2016-01-23 16:39     ` Greg KH
2016-01-24 22:05       ` Oliver Neukum
2016-01-24 22:48         ` Greg KH
2016-01-25 11:27           ` Oliver Neukum
2016-01-25 14:17     ` Jiri Kosina
2016-01-25 21:02       ` Michal Malý [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1453755751.3994.2.camel@devoid-pointer.net \
    --to=madcatxster@devoid-pointer.net \
    --cc=bjorn@mork.no \
    --cc=dmitry.torokhov@gmail.com \
    --cc=edwin@velds.nl \
    --cc=elias.vds@gmail.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=jikos@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=simon@mungewell.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome