From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756139AbcAZAPs (ORCPT ); Mon, 25 Jan 2016 19:15:48 -0500 Received: from lb2-smtp-cloud2.xs4all.net ([194.109.24.25]:35748 "EHLO lb2-smtp-cloud2.xs4all.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756071AbcAZAPq (ORCPT ); Mon, 25 Jan 2016 19:15:46 -0500 Message-ID: <1453767342.17181.26.camel@tiscali.nl> Subject: Re: [PATCH 16/22] iio: imu: Fix dependencies for !HAS_IOMEM archs From: Paul Bolle To: Richard Weinberger Cc: user-mode-linux-devel@lists.sourceforge.net, Jonathan Cameron , Hartmut Knaack , Lars-Peter Clausen , Peter Meerwald , linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org Date: Tue, 26 Jan 2016 01:15:42 +0100 In-Reply-To: <1453760661-1444-17-git-send-email-richard@nod.at> References: <1453760661-1444-1-git-send-email-richard@nod.at> <1453760661-1444-17-git-send-email-richard@nod.at> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.16.5 (3.16.5-3.fc22) Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On ma, 2016-01-25 at 23:24 +0100, Richard Weinberger wrote: > --- a/drivers/iio/imu/inv_mpu6050/Kconfig > +++ b/drivers/iio/imu/inv_mpu6050/Kconfig > config INV_MPU6050_IIO > tristate "Invensense MPU6050 devices" > depends on I2C && SYSFS > + depends on I2C_MUX Nit: if I parsed the v4.5-rc1 tree correctly I2C_MUX depends I2C. So just depends on I2C_MUX && SYSFS should also do the trick. Is it clearer to mention both I2C and I2C_MUX explicitly? (Likewise for 17/22.) > select IIO_BUFFER > select IIO_TRIGGERED_BUFFER > - select I2C_MUX > help > This driver supports the Invensense MPU6050 devices. (evolution 3.16.5 hates replying to plain text messages, so I've lost a line of context after fiddling with your message here.) Paul Bolle