From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932937AbcAZAmH (ORCPT ); Mon, 25 Jan 2016 19:42:07 -0500 Received: from mailout1.w1.samsung.com ([210.118.77.11]:28669 "EHLO mailout1.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932687AbcAZAmC (ORCPT ); Mon, 25 Jan 2016 19:42:02 -0500 X-AuditID: cbfec7f4-f79026d00000418a-6b-56a6c0d73dd6 From: Krzysztof Kozlowski To: Kyungmin Park , Sylwester Nawrocki , Mauro Carvalho Chehab , Kukjin Kim , Krzysztof Kozlowski , linux-media@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Javier Martinez Canillas Subject: [RFT 2/2] [media] exynos4-is: Add missing port parent of_node_put on error paths Date: Tue, 26 Jan 2016 09:41:46 +0900 Message-id: <1453768906-28979-2-git-send-email-k.kozlowski@samsung.com> X-Mailer: git-send-email 1.9.1 In-reply-to: <1453768906-28979-1-git-send-email-k.kozlowski@samsung.com> References: <1453768906-28979-1-git-send-email-k.kozlowski@samsung.com> X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFlrILMWRmVeSWpSXmKPExsVy+t/xa7rXDywLM9izlMfizds1TBavXxha 9D9+zWxxtukNu8Wmx9dYLS7vmsNm0bNhK6vFjPP7mCxWP6uwOPymndWBy2PTqk42j81L6j22 9N9l9+jbsorR4/MmuQDWKC6blNSczLLUIn27BK6M43+nMxW85ahYd+AqSwPjefYuRk4OCQET iTcNVxghbDGJC/fWs3UxcnEICSxllFh07gQjhPOfUeJb4xYmkCo2AWOJzcuXgFWJCDxnklg0 bSrYKGYBU4nHd9ezgNjCAtESnR9XgzWwCKhK/GxaABbnFXCXeDZjB9Q6OYmTxyazgticAh4S O/q+gNUIAdXsbF7CMoGRdwEjwypG0dTS5ILipPRcQ73ixNzi0rx0veT83E2MkID7soNx8TGr Q4wCHIxKPLwbCpaFCbEmlhVX5h5ilOBgVhLh3bsXKMSbklhZlVqUH19UmpNafIhRmoNFSZx3 7q73IUIC6YklqdmpqQWpRTBZJg5OqQbGeScfy60K+Cl0b0ZQ77KJZ3eaBt7/YndV3b03QShw +podGgeNevjdxd9aN7Icq+hs1FF9cJhloqV197E0JUOP1fWbV/DXn9x6b0+t3vnLzQ9V9IXs SqN3yft7PrFvvhC/QV9U+Jb4ta1xN1Ztr38UPLXqokpNcqPn0U8ND07vrFhl3LHqtf4aJZbi jERDLeai4kQAup90ozQCAAA= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org In fimc_md_parse_port_node() remote port parent node is get with of_graph_get_remote_port_parent() but it is not put on error path. Fixes: fa91f1056f17 ("[media] exynos4-is: Add support for asynchronous subdevices registration") Signed-off-by: Krzysztof Kozlowski --- Not tested on hardware, only built+static checkers. --- drivers/media/platform/exynos4-is/media-dev.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/media/platform/exynos4-is/media-dev.c b/drivers/media/platform/exynos4-is/media-dev.c index de0977479327..d2e564878e06 100644 --- a/drivers/media/platform/exynos4-is/media-dev.c +++ b/drivers/media/platform/exynos4-is/media-dev.c @@ -385,8 +385,10 @@ static int fimc_md_parse_port_node(struct fimc_md *fmd, else pd->fimc_bus_type = pd->sensor_bus_type; - if (WARN_ON(index >= ARRAY_SIZE(fmd->sensor))) + if (WARN_ON(index >= ARRAY_SIZE(fmd->sensor))) { + of_node_put(rem); return -EINVAL; + } fmd->sensor[index].asd.match_type = V4L2_ASYNC_MATCH_OF; fmd->sensor[index].asd.match.of.node = rem; -- 1.9.1