From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933409AbcAZAxM (ORCPT ); Mon, 25 Jan 2016 19:53:12 -0500 Received: from host.buserror.net ([209.198.135.123]:40427 "EHLO host.buserror.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932749AbcAZAxF (ORCPT ); Mon, 25 Jan 2016 19:53:05 -0500 Message-ID: <1453769574.27129.14.camel@buserror.net> From: Scott Wood To: Saurabh Sengar , qiang.zhao@freescale.com, christophe.leroy@c-s.fr, linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org Date: Mon, 25 Jan 2016 18:52:54 -0600 In-Reply-To: <1453618446-6857-1-git-send-email-saurabh.truth@gmail.com> References: <1453618446-6857-1-git-send-email-saurabh.truth@gmail.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.16.5-1ubuntu3.1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit X-SA-Exim-Connect-IP: 50.157.106.250 X-SA-Exim-Mail-From: oss@buserror.net X-Spam-Report: * -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP * -15 BAYES_00 BODY: Bayes spam probability is 0 to 1% * [score: 0.0000] Subject: Re: [PATCH] QE: Use GFP_ATOMIC while spin_lock_irqsave is held X-SA-Exim-Version: 4.2.1 (built Mon, 26 Dec 2011 16:57:07 +0000) X-SA-Exim-Scanned: Yes (on host.buserror.net) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, 2016-01-24 at 12:24 +0530, Saurabh Sengar wrote: > cpm_muram_alloc_common is called twice and both the times > spin_lock_irqsave is held. > Using GFP_KERNEL can sleep in spin_lock_irqsave context and cause > deadlock > > Signed-off-by: Saurabh Sengar > --- > Let me know if there is any other way to fix it. > Also, I would say this function should be static as it is not used in any > other file > drivers/soc/fsl/qe/qe_common.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Yes, it should be static. Do you plan to send a patch for that? -Scott