From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965796AbcAZNsB (ORCPT ); Tue, 26 Jan 2016 08:48:01 -0500 Received: from mout.kundenserver.de ([217.72.192.73]:58791 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S965470AbcAZNr5 (ORCPT ); Tue, 26 Jan 2016 08:47:57 -0500 From: Arnd Bergmann To: Herbert Xu Cc: linux-arm-kernel@lists.infradead.org, Arnd Bergmann , "David S. Miller" , linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v2 2/2] crypto: jitterentropy - always select CRYPTO_RNG Date: Tue, 26 Jan 2016 14:47:10 +0100 Message-Id: <1453816035-3070440-1-git-send-email-arnd@arndb.de> X-Mailer: git-send-email 2.7.0 In-Reply-To: <1453815902-3070323-1-git-send-email-arnd@arndb.de> References: <1453815902-3070323-1-git-send-email-arnd@arndb.de> X-Provags-ID: V03:K0:6WgmVxTbuxCFpWTkEs+8tadA2JPwL5DEus5NNEQkCjIMEWoaWWZ Stfl8jjO0FLbR9B9WWNCY0EwnMjDb92YE2m6XYF90S0sJqs5v7pF6Q0BA6B1CJLVa4KHo18 WdmyPOHdmB96OaQqSWS+tgr42DQ2Mciv7aTditkavHgS7uQ0toIysiczPSVunQRRLIwrHEN SfDecDq1Y9y1l7QiXYfsA== X-UI-Out-Filterresults: notjunk:1;V01:K0:ZekAv7P/Aic=:6v3FkqZG9oHIQagsVH70YT vUC7M/Vf8Djd2D5Utow0MnVWkRVkyhxiULqmDjk6NQsGIaJfHDc8EvBbqc7JMXuJOJkrF6IrB ruzDGy7TEdmTCnWwZARi/kiZ4D8i6IMqyIEjlgL0u8m2bAEs21cxMdavKYvZizfGwywG4iqcd TsHbWjpE2k877VfJp3RXmHGuvmDqVOotbD+oJwa+Iqfa+S0pw6KhVAlAlRbA576E6sw4ohjOT D63ZmKLOTKVZR8y1YlHD15W45G3WJp3sJEJn08dM8a0iEpLpCr7SEg6Z0+6ScO70dGcl/gFVN 9/RWZY2MJFCBxAVRls7oPBTsTa/m9zmrIaoWx/yrfh9VuD3ACmRTaU5uHhagj8ocdJwkKQHQX P9SjD3koEwW2b4SmV88fy6pJIQxMsTA4GPKw3QSYQVnTqHFaQqCi0n6OI9q0uCS1wPumH/hv5 9buMIBZL7kSV3ouEAwgac2gyqqR1h8J0EzstuI0hxVEeOjNkrlSHTZF/cULWTW8wNAUOBC7SY QbNS/+4trODE+SS8Fvzx69VbZOaa5+iYGa8WoDcTD91HZvowWahCUgD+GFtXR0VP8fi+wmNzD VPqEBBSpheInhVKxjC567OFYmEPU1MJzdOgJVfU0NpWBDNLu4Ddbb1gg9SIGpLiGh9LyZuUFl YwbrxuxksGDz5lwtDp4cdVYG2QHxSG+NynAz6tVbkOASu6vBA8AS/jOvH45D5oZdUkMw= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org When building the jitterentropy driver by itself, we get a link error when CRYPTO_RNG is not enabled as well: crypto/built-in.o: In function `jent_mod_init': jitterentropy-kcapi.c:(.init.text+0x98): undefined reference to `crypto_register_rng' crypto/built-in.o: In function `jent_mod_exit': jitterentropy-kcapi.c:(.exit.text+0x60): undefined reference to `crypto_unregister_rng' This adds a 'select CRYPTO_RNG' to CRYPTO_JITTERENTROPY to ensure the API is always there when it's used, not just when DRBG is also enabled. CRYPTO_DRBG would set it implicitly through CRYPTO_JITTERENTROPY now, but this leaves it in place to make it explicit what the driver does. Signed-off-by: Arnd Bergmann --- crypto/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/crypto/Kconfig b/crypto/Kconfig index 3be07ad1d80d..88248821af82 100644 --- a/crypto/Kconfig +++ b/crypto/Kconfig @@ -1595,6 +1595,7 @@ endif # if CRYPTO_DRBG_MENU config CRYPTO_JITTERENTROPY tristate "Jitterentropy Non-Deterministic Random Number Generator" + select CRYPTO_RNG help The Jitterentropy RNG is a noise that is intended to provide seed to another RNG. The RNG does not -- 2.7.0