From: Javier Martinez Canillas <javier@osg.samsung.com>
To: linux-kernel@vger.kernel.org
Cc: Kukjin Kim <kgene@kernel.org>,
rtc-linux@googlegroups.com, Andi Shyti <andi.shyti@samsung.com>,
Chanwoo Choi <cw00.choi@samsung.com>,
Alexandre Belloni <alexandre.belloni@free-electrons.com>,
Krzysztof Kozlowski <k.kozlowski@samsung.com>,
Laxman Dewangan <ldewangan@nvidia.com>,
linux-samsung-soc@vger.kernel.org,
Javier Martinez Canillas <javier@osg.samsung.com>
Subject: [PATCH v4 01/10] rtc: max77686: Fix max77686_rtc_read_alarm() return value
Date: Wed, 27 Jan 2016 00:36:37 -0300 [thread overview]
Message-ID: <1453865806-4661-2-git-send-email-javier@osg.samsung.com> (raw)
In-Reply-To: <1453865806-4661-1-git-send-email-javier@osg.samsung.com>
The function is always returning zero even in case of failures since
the ret value was not propagated to the callers. Fix the error path.
Reported-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
Reviewed-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
Tested-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
Acked-by: Laxman Dewangan <ldewangan@nvidia.com>
Reviewed-by: Andi Shyti <andi.shyti@samsung.com>
---
Changes in v4:
- Add Andi Shyti's Reviewed-by to patch #1.
Changes in v3:
- Add Krzysztof Kozlowski's Reviewed-by and Tested-by to patch #1.
- Add Laxman Dewangan's Acked-by tag to patch #1.
Changes in v2: None
drivers/rtc/rtc-max77686.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/rtc/rtc-max77686.c b/drivers/rtc/rtc-max77686.c
index 7184a0eda793..6653c3d11b66 100644
--- a/drivers/rtc/rtc-max77686.c
+++ b/drivers/rtc/rtc-max77686.c
@@ -235,7 +235,7 @@ static int max77686_rtc_read_alarm(struct device *dev, struct rtc_wkalrm *alrm)
out:
mutex_unlock(&info->lock);
- return 0;
+ return ret;
}
static int max77686_rtc_stop_alarm(struct max77686_rtc_info *info)
--
2.5.0
next prev parent reply other threads:[~2016-01-27 3:37 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-27 3:36 [PATCH v4 00/10] rtc: max77686: Extend driver and add max77802 support Javier Martinez Canillas
2016-01-27 3:36 ` Javier Martinez Canillas [this message]
2016-01-27 3:36 ` [PATCH v4 02/10] rtc: max77686: Use ARRAY_SIZE() instead of current array length Javier Martinez Canillas
2016-01-27 5:57 ` Laxman Dewangan
2016-01-27 3:36 ` [PATCH v4 03/10] rtc: max77686: Use usleep_range() instead of msleep() Javier Martinez Canillas
2016-01-27 3:36 ` [PATCH v4 04/10] rtc: max77686: Use a driver data struct instead hard-coded values Javier Martinez Canillas
2016-01-27 3:36 ` [PATCH v4 05/10] rtc: max77686: Add an indirection level to access RTC registers Javier Martinez Canillas
2016-01-27 3:36 ` [PATCH v4 06/10] rtc: max77686: Add max77802 support Javier Martinez Canillas
2016-01-27 4:23 ` Krzysztof Kozlowski
2016-01-27 4:37 ` Javier Martinez Canillas
2016-01-27 3:36 ` [PATCH v4 07/10] rtc: max77686: Fix unsupported year message Javier Martinez Canillas
2016-01-27 4:24 ` Krzysztof Kozlowski
2016-01-27 3:36 ` [PATCH v4 08/10] rtc: Remove Maxim 77802 driver Javier Martinez Canillas
2016-01-27 3:36 ` [PATCH v4 09/10] ARM: exynos_defconfig: Remove MAX77802 RTC Kconfig symbol Javier Martinez Canillas
2016-01-27 3:36 ` [PATCH v4 10/10] ARM: multi_v7_defconfig: " Javier Martinez Canillas
2016-01-28 1:14 ` [PATCH v4 00/10] rtc: max77686: Extend driver and add max77802 support Andi Shyti
2016-01-31 12:05 ` Alexandre Belloni
2016-01-31 12:11 ` [rtc-linux] " Krzysztof Kozlowski
2016-02-04 22:56 ` Alexandre Belloni
2016-02-05 0:18 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1453865806-4661-2-git-send-email-javier@osg.samsung.com \
--to=javier@osg.samsung.com \
--cc=alexandre.belloni@free-electrons.com \
--cc=andi.shyti@samsung.com \
--cc=cw00.choi@samsung.com \
--cc=k.kozlowski@samsung.com \
--cc=kgene@kernel.org \
--cc=ldewangan@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=rtc-linux@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®