From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753482AbcA0FL1 (ORCPT ); Wed, 27 Jan 2016 00:11:27 -0500 Received: from lucky1.263xmail.com ([211.157.147.131]:60630 "EHLO lucky1.263xmail.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751805AbcA0FLY (ORCPT ); Wed, 27 Jan 2016 00:11:24 -0500 X-263anti-spam: KSV:0; X-MAIL-GRAY: 1 X-MAIL-DELIVERY: 0 X-KSVirus-check: 0 X-ABS-CHECKED: 4 X-ADDR-CHECKED: 0 X-RL-SENDER: shawn.lin@rock-chips.com X-FST-TO: ulf.hansson@linaro.org X-SENDER-IP: 58.22.7.114 X-LOGIN-NAME: shawn.lin@rock-chips.com X-UNIQUE-TAG: X-ATTACHMENT-NUM: 0 X-DNS-TYPE: 0 From: Shawn Lin To: Ulf Hansson Cc: bcm-kernel-feedback-list@broadcom.com, linux-rpi-kernel@lists.infradead.org, linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org, Shawn Lin , Michal Simek , soren.brinkmann@xilinx.com Subject: [RFC PATCH 04/21] mmc: sdhci-of-arasan: consolidate parsing path Date: Wed, 27 Jan 2016 13:06:50 +0800 Message-Id: <1453871210-3453-1-git-send-email-shawn.lin@rock-chips.com> X-Mailer: git-send-email 1.8.0 In-Reply-To: <1453871155-3283-1-git-send-email-shawn.lin@rock-chips.com> References: <1453871155-3283-1-git-send-email-shawn.lin@rock-chips.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This patch remove mmc_of_parse and check return value of sdhci_get_of_property. Cc: Michal Simek Cc: soren.brinkmann@xilinx.com Signed-off-by: Shawn Lin --- drivers/mmc/host/sdhci-of-arasan.c | 11 ++++------- 1 file changed, 4 insertions(+), 7 deletions(-) diff --git a/drivers/mmc/host/sdhci-of-arasan.c b/drivers/mmc/host/sdhci-of-arasan.c index 75379cb..b653ec7 100644 --- a/drivers/mmc/host/sdhci-of-arasan.c +++ b/drivers/mmc/host/sdhci-of-arasan.c @@ -177,17 +177,14 @@ static int sdhci_arasan_probe(struct platform_device *pdev) host->quirks2 |= SDHCI_QUIRK2_HOST_NO_CMD23; } - sdhci_get_of_property(pdev); + ret = sdhci_get_of_property(pdev); + if (ret) + goto clk_disable_all; + pltfm_host = sdhci_priv(host); pltfm_host->priv = sdhci_arasan; pltfm_host->clk = clk_xin; - ret = mmc_of_parse(host->mmc); - if (ret) { - dev_err(&pdev->dev, "parsing dt failed (%u)\n", ret); - goto clk_disable_all; - } - ret = sdhci_add_host(host); if (ret) goto err_pltfm_free; -- 2.3.7