From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753565AbcA0FMW (ORCPT ); Wed, 27 Jan 2016 00:12:22 -0500 Received: from lucky1.263xmail.com ([211.157.147.133]:33095 "EHLO lucky1.263xmail.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753245AbcA0FMS (ORCPT ); Wed, 27 Jan 2016 00:12:18 -0500 X-263anti-spam: KSV:0; X-MAIL-GRAY: 1 X-MAIL-DELIVERY: 0 X-KSVirus-check: 0 X-ABS-CHECKED: 4 X-ADDR-CHECKED: 0 X-RL-SENDER: shawn.lin@rock-chips.com X-FST-TO: ulf.hansson@linaro.org X-SENDER-IP: 58.22.7.114 X-LOGIN-NAME: shawn.lin@rock-chips.com X-UNIQUE-TAG: <530da98ecc677019b182435e97dc3ccb> X-ATTACHMENT-NUM: 0 X-DNS-TYPE: 0 From: Shawn Lin To: Ulf Hansson Cc: bcm-kernel-feedback-list@broadcom.com, linux-rpi-kernel@lists.infradead.org, linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org, Shawn Lin , Barry Song , Weijun Yang Subject: [RFC PATCH 08/21] mmc: sdhci-sirf: check sdhci_get_of_property return value Date: Wed, 27 Jan 2016 13:07:44 +0800 Message-Id: <1453871264-3640-1-git-send-email-shawn.lin@rock-chips.com> X-Mailer: git-send-email 1.8.0 In-Reply-To: <1453871155-3283-1-git-send-email-shawn.lin@rock-chips.com> References: <1453871155-3283-1-git-send-email-shawn.lin@rock-chips.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org sdhci_get_of_property may failed while probing, so we check the return value here. Cc: Barry Song Cc: Weijun Yang Signed-off-by: Shawn Lin --- drivers/mmc/host/sdhci-sirf.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/mmc/host/sdhci-sirf.c b/drivers/mmc/host/sdhci-sirf.c index 34866f6..3f8499f 100644 --- a/drivers/mmc/host/sdhci-sirf.c +++ b/drivers/mmc/host/sdhci-sirf.c @@ -195,7 +195,9 @@ static int sdhci_sirf_probe(struct platform_device *pdev) priv = sdhci_pltfm_priv(pltfm_host); priv->gpio_cd = gpio_cd; - sdhci_get_of_property(pdev); + ret = sdhci_get_of_property(pdev); + if (ret) + return ret; ret = clk_prepare_enable(pltfm_host->clk); if (ret) -- 2.3.7