From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753710AbcA0Gqa (ORCPT ); Wed, 27 Jan 2016 01:46:30 -0500 Received: from mailout1.w1.samsung.com ([210.118.77.11]:22887 "EHLO mailout1.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751642AbcA0Gq2 (ORCPT ); Wed, 27 Jan 2016 01:46:28 -0500 X-AuditID: cbfec7f4-f79026d00000418a-5a-56a867c1f98c From: Krzysztof Kozlowski To: Chanwoo Choi , Krzysztof Kozlowski , Alessandro Zummo , Alexandre Belloni , linux-kernel@vger.kernel.org, rtc-linux@googlegroups.com, Javier Martinez Canillas Cc: Andi Shyti , Laxman Dewangan Subject: [PATCH] rtc: max77686: Cleanup and reduce dmesg output Date: Wed, 27 Jan 2016 15:46:11 +0900 Message-id: <1453877171-30510-1-git-send-email-k.kozlowski@samsung.com> X-Mailer: git-send-email 1.9.1 X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFupjluLIzCtJLcpLzFFi42I5/e/4Nd2D6SvCDJ4fEbRYcvEqu0XHtcVM FtuPPGO1uP7lOavFm7drmCxevzC0WLpvNYvF5V1z2Cz2d3YwOnB6PNl0kdFjz8STbB69ze/Y PLb032X36NuyitFj+ryfTB6fN8kFsEdx2aSk5mSWpRbp2yVwZbTfTCno1as407mfrYHxoEoX IyeHhICJxPb1F1ggbDGJC/fWs4HYQgJLGSX2L0zpYuQCsv8zSpx5/I4VJMEmYCyxefkSNpCE iMBGJomHT3aAdTAL+Ev8ajgDNklYwF6ipWcmO4jNIqAqMalhMzOIzSvgLvFvwVNWiG1yEieP TWadwMi9gJFhFaNoamlyQXFSeq6hXnFibnFpXrpecn7uJkZIKH3Zwbj4mNUhRgEORiUe3hv7 l4cJsSaWFVfmHmKU4GBWEuEVj1wRJsSbklhZlVqUH19UmpNafIhRmoNFSZx37q73IUIC6Ykl qdmpqQWpRTBZJg5OqQbG2RfOpHzZWRaY+E3iu8klseaHt3idlnUmhAeJcE4p3HMkM3h2Xe/D FH1Xz9Muh3J9tl9JVb0Sx7rq4foDuZLzby6p8P6scD6U18twaVFfzZy/FVcclHrEdXbHm1zn mTtX13PXw7tCXVfFTn3RnJBdeqvouE+nxa//7PkLJ87v3v3aXG6mL9sbJZbijERDLeai4kQA S0KmpSECAAA= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Cleanup of entire driver of its dmesg output: 1. Remove printing of the function name, because printing device name is sufficient. This also makes the dev_err()-like functions more compact and readable (not need of line break). 2. Lower from info to debug printing of each RTC interrupt (no need to make noise on each alarm). 3. Remove dev_info() at beginning of probe because a message is already always printed by either probe failure or from registering the RTC device as /dev/rtcX. Signed-off-by: Krzysztof Kozlowski --- Patch rebased on top of Javier's v4: [PATCH v4 00/10] rtc: max77686: Extend driver and add max77802 support http://www.spinics.net/lists/arm-kernel/msg477194.html Feel free to join with these series. --- drivers/rtc/rtc-max77686.c | 39 ++++++++++++++------------------------- 1 file changed, 14 insertions(+), 25 deletions(-) diff --git a/drivers/rtc/rtc-max77686.c b/drivers/rtc/rtc-max77686.c index da47b1d85793..5a03e1ecad83 100644 --- a/drivers/rtc/rtc-max77686.c +++ b/drivers/rtc/rtc-max77686.c @@ -271,8 +271,8 @@ static int max77686_rtc_update(struct max77686_rtc_info *info, info->drv_data->map[REG_RTC_UPDATE0], data, data); if (ret < 0) - dev_err(info->dev, "%s: fail to write update reg(ret=%d, data=0x%x)\n", - __func__, ret, data); + dev_err(info->dev, "Fail to write update reg(ret=%d, data=0x%x)\n", + ret, data); else { /* Minimum delay required before RTC update. */ usleep_range(delay, delay * 2); @@ -297,7 +297,7 @@ static int max77686_rtc_read_time(struct device *dev, struct rtc_time *tm) info->drv_data->map[REG_RTC_SEC], data, ARRAY_SIZE(data)); if (ret < 0) { - dev_err(info->dev, "%s: fail to read time reg(%d)\n", __func__, ret); + dev_err(info->dev, "Fail to read time reg(%d)\n", ret); goto out; } @@ -326,8 +326,7 @@ static int max77686_rtc_set_time(struct device *dev, struct rtc_time *tm) info->drv_data->map[REG_RTC_SEC], data, ARRAY_SIZE(data)); if (ret < 0) { - dev_err(info->dev, "%s: fail to write time reg(%d)\n", __func__, - ret); + dev_err(info->dev, "Fail to write time reg(%d)\n", ret); goto out; } @@ -355,8 +354,7 @@ static int max77686_rtc_read_alarm(struct device *dev, struct rtc_wkalrm *alrm) ret = regmap_bulk_read(info->max77686->rtc_regmap, map[REG_ALARM1_SEC], data, ARRAY_SIZE(data)); if (ret < 0) { - dev_err(info->dev, "%s:%d fail to read alarm reg(%d)\n", - __func__, __LINE__, ret); + dev_err(info->dev, "Fail to read alarm reg(%d)\n", ret); goto out; } @@ -394,8 +392,7 @@ static int max77686_rtc_read_alarm(struct device *dev, struct rtc_wkalrm *alrm) alrm->pending = 0; ret = regmap_read(info->max77686->regmap, MAX77686_REG_STATUS2, &val); if (ret < 0) { - dev_err(info->dev, "%s:%d fail to read status2 reg(%d)\n", - __func__, __LINE__, ret); + dev_err(info->dev, "Fail to read status2 reg(%d)\n", ret); goto out; } @@ -426,8 +423,7 @@ static int max77686_rtc_stop_alarm(struct max77686_rtc_info *info) map[REG_ALARM1_SEC], data, ARRAY_SIZE(data)); if (ret < 0) { - dev_err(info->dev, "%s: fail to read alarm reg(%d)\n", - __func__, ret); + dev_err(info->dev, "Fail to read alarm reg(%d)\n", ret); goto out; } @@ -452,8 +448,7 @@ static int max77686_rtc_stop_alarm(struct max77686_rtc_info *info) } if (ret < 0) { - dev_err(info->dev, "%s: fail to write alarm reg(%d)\n", - __func__, ret); + dev_err(info->dev, "Fail to write alarm reg(%d)\n", ret); goto out; } @@ -481,8 +476,7 @@ static int max77686_rtc_start_alarm(struct max77686_rtc_info *info) map[REG_ALARM1_SEC], data, ARRAY_SIZE(data)); if (ret < 0) { - dev_err(info->dev, "%s: fail to read alarm reg(%d)\n", - __func__, ret); + dev_err(info->dev, "Fail to read alarm reg(%d)\n", ret); goto out; } @@ -508,8 +502,7 @@ static int max77686_rtc_start_alarm(struct max77686_rtc_info *info) } if (ret < 0) { - dev_err(info->dev, "%s: fail to write alarm reg(%d)\n", - __func__, ret); + dev_err(info->dev, "Fail to write alarm reg(%d)\n", ret); goto out; } @@ -539,8 +532,7 @@ static int max77686_rtc_set_alarm(struct device *dev, struct rtc_wkalrm *alrm) data, ARRAY_SIZE(data)); if (ret < 0) { - dev_err(info->dev, "%s: fail to write alarm reg(%d)\n", - __func__, ret); + dev_err(info->dev, "Fail to write alarm reg(%d)\n", ret); goto out; } @@ -575,7 +567,7 @@ static irqreturn_t max77686_rtc_alarm_irq(int irq, void *data) { struct max77686_rtc_info *info = data; - dev_info(info->dev, "%s:irq(%d)\n", __func__, irq); + dev_dbg(info->dev, "RTC alarm IRQ: %d\n", irq); rtc_update_irq(info->rtc_dev, 1, RTC_IRQF | RTC_AF); @@ -605,8 +597,7 @@ static int max77686_rtc_init_reg(struct max77686_rtc_info *info) info->drv_data->map[REG_RTC_CONTROLM], data, ARRAY_SIZE(data)); if (ret < 0) { - dev_err(info->dev, "%s: fail to write controlm reg(%d)\n", - __func__, ret); + dev_err(info->dev, "Fail to write controlm reg(%d)\n", ret); return ret; } @@ -621,8 +612,6 @@ static int max77686_rtc_probe(struct platform_device *pdev) const struct platform_device_id *id = platform_get_device_id(pdev); int ret; - dev_info(&pdev->dev, "%s\n", __func__); - info = devm_kzalloc(&pdev->dev, sizeof(struct max77686_rtc_info), GFP_KERNEL); if (!info) @@ -662,7 +651,7 @@ static int max77686_rtc_probe(struct platform_device *pdev) if (!max77686->rtc_irq_data) { ret = -EINVAL; - dev_err(&pdev->dev, "%s: no RTC regmap IRQ chip\n", __func__); + dev_err(&pdev->dev, "No RTC regmap IRQ chip\n"); goto err_rtc; } -- 1.9.1