From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754810AbcA0P73 (ORCPT ); Wed, 27 Jan 2016 10:59:29 -0500 Received: from mout.kundenserver.de ([212.227.17.13]:64187 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753248AbcA0P7W (ORCPT ); Wed, 27 Jan 2016 10:59:22 -0500 From: Arnd Bergmann To: "Martin K. Petersen" , James.Bottomley@HansenPartnership.com Cc: linux-arm-kernel@lists.infradead.org, Arnd Bergmann , linux-scsi@vger.kernel.org, "James E.J. Bottomley" , Russell King , linux-kernel@vger.kernel.org Subject: [PATCH 4/7] scsi: fas216: avoid fas216_log_setup for loadable module Date: Wed, 27 Jan 2016 16:57:20 +0100 Message-Id: <1453910247-3447628-5-git-send-email-arnd@arndb.de> X-Mailer: git-send-email 2.7.0 In-Reply-To: <1453910247-3447628-1-git-send-email-arnd@arndb.de> References: <1453910247-3447628-1-git-send-email-arnd@arndb.de> X-Provags-ID: V03:K0:u2IaGMNIv1cysA8lR08duHaa0zAi8lfZ2oX4yU8KdGJBtrSd+c0 hNe5IX9RwO3VbVIBPW0/Lhay62Z+SuxKcXBs7wXVjcaciC6nvWEGpNp6zzTE4+6Cy8UP0kQ giTqQWeUmR/bENFGGPMw+2LOSFK6q6bIFHrwE2EDPKG2EfaS8F+3mRxlSeYEYGxnck/LHIJ Ct19idyZVYuC2EbOGbYTA== X-UI-Out-Filterresults: notjunk:1;V01:K0:mKw5/SVMhFI=:hNIghXMwk8jFcbL0Tz484O QpRRFzAre5t3bGMRC+kgcaUfd1Ivs7zV2n+2vZfExHATHwD4jypQLD+HPeWd8h3jytI9WiUSI s6hE5lMMbHN1Z180Lj7B7vHluRiW4laCzkDlFbDFcCsJJNumz0jW+DdHjswk8CvWcQb21D4lt N3a1tLUq0UEpCW1rx3qP/mfYwNokcVJryPN+D3NQxx3AEQjclGmdu1QBGtE/hG/WZ6hxTyhbB JM6UvFVqUa4QowcDBaPYIfcsetFB3yzAwA6mbPJUjCLgze1tTcX3rOPbQraFpgS8F0PR+OnNz jIE1vt97PFOAY8bvuWrzfDFGfwelz3whQUsIwUgBsAmyz+CcU6BfKwlRUZcL6UdHZxKVKi5Ch k/bl1GneW+mCDZdgyavRlSWf69HKEPQK5cfU0Dr9X9qzYK8wL4DtIxpJwjzDAm8jIZ6LBsCXr K5OYGhcKFPIQxeXKVOxV/9Q2b9TungX0pkU4RGPILJ8PBYBUHCueI+edd59/qycsZwU7NpcCt fdOlURRnB5D9h+dzHOvm0EgZE3C81dEgneb4Bp/HkkbcVe/IxO8544lC+/AivA/Fd+8L3BnEL Ma1zo2qntfaCfMT/PrPDveW0zadqD5gLAhsJZPkdANRCLf1Oua9Vc+s8SlP5xd1teO8+UPCPc otgfacgYgu0yi8Uc1xeGivs7fFczl1wYydZ26G/6OCp47RV9xUcKOukOXFxvTlpi1r8A= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org We get a warning for the fas216 driver when it is compiled as a loadable module, as the __setup() functions are never called then: scsi/arm/fas216.c:101:19: warning: 'fas216_log_setup' defined but not used [-Wunused-function] static int __init fas216_log_setup(char *str) This adds an #ifndef MODULE around the definition to shut up the warning and clarify for the reader when it is used or not. Signed-off-by: Arnd Bergmann --- drivers/scsi/arm/fas216.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/scsi/arm/fas216.c b/drivers/scsi/arm/fas216.c index decdc71b6b86..24388795ee9a 100644 --- a/drivers/scsi/arm/fas216.c +++ b/drivers/scsi/arm/fas216.c @@ -98,6 +98,7 @@ static int level_mask = LOG_ERROR; module_param(level_mask, int, 0644); +#ifndef MODULE static int __init fas216_log_setup(char *str) { char *s; @@ -138,6 +139,7 @@ static int __init fas216_log_setup(char *str) } __setup("fas216_logging=", fas216_log_setup); +#endif static inline unsigned char fas216_readb(FAS216_Info *info, unsigned int reg) { -- 2.7.0