From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932660AbcA0QsH (ORCPT ); Wed, 27 Jan 2016 11:48:07 -0500 Received: from eusmtp01.atmel.com ([212.144.249.243]:8327 "EHLO eusmtp01.atmel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932118AbcA0QsC (ORCPT ); Wed, 27 Jan 2016 11:48:02 -0500 From: Nicolas Ferre To: , CC: , Cyrille Pitchen , Wenyou Yang , , , , Nicolas Ferre Subject: [PATCH] spi: atmel: fix gpio chip-select in case of non-DT platform Date: Wed, 27 Jan 2016 17:48:32 +0100 Message-ID: <1453913312-18108-1-git-send-email-nicolas.ferre@atmel.com> X-Mailer: git-send-email 2.1.3 MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Cyrille Pitchen The non-DT platform that uses this driver (actually the AVR32) was taking a bad branch for determining if the IP would use gpio for CS. Adding the presence of DT as a condition fixes this issue. Signed-off-by: Cyrille Pitchen [nicolas.ferre@atmel.com: extract from ml discussion] Reported-by: Mans Rullgard Fixes: 4820303480a1 ("spi: atmel: add support for the internal chip-select of the spi controller") Cc: # 4.2+ Signed-off-by: Nicolas Ferre --- drivers/spi/spi-atmel.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/spi/spi-atmel.c b/drivers/spi/spi-atmel.c index aebad36391c9..8feac599e9ab 100644 --- a/drivers/spi/spi-atmel.c +++ b/drivers/spi/spi-atmel.c @@ -1571,6 +1571,7 @@ static int atmel_spi_probe(struct platform_device *pdev) as->use_cs_gpios = true; if (atmel_spi_is_v2(as) && + pdev->dev.of_node && !of_get_property(pdev->dev.of_node, "cs-gpios", NULL)) { as->use_cs_gpios = false; master->num_chipselect = 4; -- 2.1.3