From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S935271AbcA0WvK (ORCPT ); Wed, 27 Jan 2016 17:51:10 -0500 Received: from p3plsmtps2ded02.prod.phx3.secureserver.net ([208.109.80.59]:42938 "EHLO p3plsmtps2ded02.prod.phx3.secureserver.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934735AbcA0Wud (ORCPT ); Wed, 27 Jan 2016 17:50:33 -0500 x-originating-ip: 72.167.245.219 From: "K. Y. Srinivasan" To: gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org, devel@linuxdriverproject.org, olaf@aepfle.de, apw@canonical.com, vkuznets@redhat.com, jasowang@redhat.com Cc: "K. Y. Srinivasan" Subject: [PATCH 04/13] Drivers: hv: vmbus: don't manipulate with clocksources on crash Date: Wed, 27 Jan 2016 16:26:46 -0800 Message-Id: <1453940815-26096-4-git-send-email-kys@microsoft.com> X-Mailer: git-send-email 1.7.4.1 In-Reply-To: <1453940815-26096-1-git-send-email-kys@microsoft.com> References: <1453940792-25878-1-git-send-email-kys@microsoft.com> <1453940815-26096-1-git-send-email-kys@microsoft.com> X-CMAE-Envelope: MS4wfHTTOf3ujQtMVUv2bDrzddDVMWI6UbAuCWdA8PyXhHSOjL7XS4ddBgv1056AEEsxb0Igz5iUs6/AlstSvP3cHRb0lI7ecsOPREq4z2YDIh5+eKPs7cr8 oZ39xrNO3KwtmwPZfP0loVLCOXCVHmUPA3DAN6lucpx0bYIjdYrxu3QAIKIYMjeycQKnXWFxPVXDkSXabV2wvgL9wHDXmr0RPgY5vdev8PSKE584ppVEW7Bq RI1KuIb7rX6gw/ZQ6aG2N/bfPLemmUzjZJlmQ7fbfEGviorsURS9mi44CUDx/Dzj86XQheV+UNkRl3K3ZmfntuS/hhezEFL3LzE+0AbCyhbnuZtuRESVxSg0 EEC+2C6R4+1yxb+yZJyu6NuOxgyq8CZ/MS+iJKXZAfR8CvQmkYzYPSa6NDy3/G0e4eHdeHiS Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Vitaly Kuznetsov clocksource_change_rating() involves mutex usage and can't be called in interrupt context. It also makes sense to avoid doing redundant work on crash. Signed-off-by: Vitaly Kuznetsov Signed-off-by: K. Y. Srinivasan --- drivers/hv/hv.c | 10 ++++++++-- 1 files changed, 8 insertions(+), 2 deletions(-) diff --git a/drivers/hv/hv.c b/drivers/hv/hv.c index 11bca51..257de21 100644 --- a/drivers/hv/hv.c +++ b/drivers/hv/hv.c @@ -295,8 +295,14 @@ void hv_cleanup(void) * Cleanup the TSC page based CS. */ if (ms_hyperv.features & HV_X64_MSR_REFERENCE_TSC_AVAILABLE) { - clocksource_change_rating(&hyperv_cs_tsc, 10); - clocksource_unregister(&hyperv_cs_tsc); + /* + * Crash can happen in an interrupt context and unregistering + * a clocksource is impossible and redundant in this case. + */ + if (!oops_in_progress) { + clocksource_change_rating(&hyperv_cs_tsc, 10); + clocksource_unregister(&hyperv_cs_tsc); + } hypercall_msr.as_uint64 = 0; wrmsrl(HV_X64_MSR_REFERENCE_TSC, hypercall_msr.as_uint64); -- 1.7.4.1