From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S967388AbcA1Ans (ORCPT ); Wed, 27 Jan 2016 19:43:48 -0500 Received: from smtprelay0191.hostedemail.com ([216.40.44.191]:47276 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S965544AbcA1Ano (ORCPT ); Wed, 27 Jan 2016 19:43:44 -0500 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,joe@perches.com,:::::::::::,RULES_HIT:41:355:379:541:599:800:960:973:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1540:1593:1594:1711:1730:1747:1777:1792:2393:2553:2559:2562:2828:3138:3139:3140:3141:3142:3352:3622:3865:3866:3867:3870:3871:3872:3874:4321:5007:6119:6261:7903:10004:10400:10848:11026:11232:11658:11783:11914:12043:12517:12519:12740:13069:13095:13311:13357:13894:14659:21080,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0,LFtime:1,LUA_SUMMARY:none X-HE-Tag: lip63_77b8cc9fb2c14 X-Filterd-Recvd-Size: 2019 Message-ID: <1453941821.10099.33.camel@perches.com> Subject: Re: [PATCH] Remove ambiguous logging for "Unsupported brightness interface" From: Joe Perches To: Eric Curtin Cc: platform-driver-x86@vger.kernel.org, Kernel development list , Darren Hart , Henrique de Moraes Holschuh , ibm-acpi-devel@lists.sourceforge.net Date: Wed, 27 Jan 2016 16:43:41 -0800 In-Reply-To: References: <1453937211.10099.31.camel@perches.com> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.18.3-1ubuntu1 Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 2016-01-28 at 00:36 +0000, Eric Curtin wrote: > On 27 January 2016 at 23:26, Joe Perches wrote: > > On Wed, 2016-01-27 at 22:14 +0000, Eric Curtin wrote: > > > Message gets logged on machines that are well supported. [] > > diff --git a/drivers/platform/x86/thinkpad_acpi.c b/drivers/platform/x86/thinkpad_acpi.c [] > > +       pr_info("detected %u brightness levels\n", bright_maxlvl + 1); > >  } > > > >  static int __init brightness_init(struct ibm_init_struct *iibm) > > Maybe, but the other logging issues kinda mean something. There are > many, many reports of people thinking their brightness interface is > broken because of this logging message, when in reality the i915 driver > supports their devices just fine as previously stated. That's why I suggest changing it to show the number of brightness levels detected on any device.