From: Shawn Lin <shawn.lin@rock-chips.com>
To: Jaehoon Chung <jh80.chung@samsung.com>,
Ulf Hansson <ulf.hansson@linaro.org>
Cc: linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org,
Shawn Lin <shawn.lin@rock-chips.com>
Subject: [PATCH 0/4] Cleanup setup_clock callback from dw_mmc
Date: Thu, 28 Jan 2016 09:30:16 +0800 [thread overview]
Message-ID: <1453944616-16224-1-git-send-email-shawn.lin@rock-chips.com> (raw)
Hello Jeahoon
Currently dw_mmc is a little too queen-size. As we had cleanup
prepare_command callback some days before, there are also some
ones deserve to remove. Also we should avoid add new quirks or
callbacks into dw_mmc in order to avoid the dilemma sdhci meets
now.
This patchset remove setup_clock callback. Obviously, adding a
callback just for one-time-used clk stuff makes no sense. We combine
what setup_clock does before into init callback. For exynos platfrom,
it needs call init hook after resume, so we add new argument in init
hook to indicate whether it needs do clk stuff or not.
Shawn Lin (4):
mmc: dw_mmc-rockchip: remove setup_clock for rockchip
mmc: dw_mmc: add setup_clk for init hook
mmc: dw_mmc-exynos: remove dw_mci_exynos_setup_clock
mmc: dw_mmc: remove setup_clock callback
drivers/mmc/host/dw_mmc-exynos.c | 15 ++++-----------
drivers/mmc/host/dw_mmc-rockchip.c | 14 +++++---------
drivers/mmc/host/dw_mmc.c | 11 +----------
drivers/mmc/host/dw_mmc.h | 3 +--
4 files changed, 11 insertions(+), 32 deletions(-)
--
2.3.7
next reply other threads:[~2016-01-28 1:35 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-28 1:30 Shawn Lin [this message]
2016-01-28 1:30 ` [PATCH 1/4] mmc: dw_mmc-rockchip: remove setup_clock for rockchip Shawn Lin
2016-01-28 1:31 ` [PATCH 2/4] mmc: dw_mmc: add setup_clk for init hook Shawn Lin
2016-02-04 6:04 ` Jaehoon Chung
2016-02-12 11:30 ` Shawn Lin
2016-01-28 1:31 ` [PATCH 3/4] mmc: dw_mmc-exynos: remove dw_mci_exynos_setup_clock Shawn Lin
2016-01-28 1:31 ` [PATCH 4/4] mmc: dw_mmc: remove setup_clock callback Shawn Lin
2016-03-31 6:38 ` Jaehoon Chung
2016-03-31 6:37 ` [PATCH 0/4] Cleanup setup_clock callback from dw_mmc Jaehoon Chung
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1453944616-16224-1-git-send-email-shawn.lin@rock-chips.com \
--to=shawn.lin@rock-chips.com \
--cc=jh80.chung@samsung.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®