From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752695AbcA2HIR (ORCPT ); Fri, 29 Jan 2016 02:08:17 -0500 Received: from mail-pa0-f51.google.com ([209.85.220.51]:34132 "EHLO mail-pa0-f51.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750871AbcA2HIQ (ORCPT ); Fri, 29 Jan 2016 02:08:16 -0500 From: Rakhi Sharma To: gregkh@linuxfoundation.org Cc: linux-kernel@vger.kernel.org, florian.c.schilhabel@googlemail.com, Rakhi Sharma Subject: [PATCH] Staging: rtl8712: rtl8712_cmd: Fixed a warning. Date: Fri, 29 Jan 2016 12:37:06 +0530 Message-Id: <1454051226-10448-1-git-send-email-rakhish1994@gmail.com> X-Mailer: git-send-email 1.9.1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Warning:Comparisons should place the constant on the right side of the test Fixed by placing the comparisions constant on right side of the test. Signed-off-by: Rakhi Sharma --- drivers/staging/rtl8712/rtl8712_cmd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/rtl8712/rtl8712_cmd.c b/drivers/staging/rtl8712/rtl8712_cmd.c index 9b91609..86a9089 100644 --- a/drivers/staging/rtl8712/rtl8712_cmd.c +++ b/drivers/staging/rtl8712/rtl8712_cmd.c @@ -293,7 +293,7 @@ u8 r8712_fw_cmd(struct _adapter *pAdapter, u32 cmd) r8712_write32(pAdapter, IOCMD_CTRL_REG, cmd); msleep(100); - while ((0 != r8712_read32(pAdapter, IOCMD_CTRL_REG)) && + while ((r8712_read32(pAdapter, IOCMD_CTRL_REG != 0)) && (pollingcnts > 0)) { pollingcnts--; msleep(20); -- 1.9.1