mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Arnd Bergmann <arnd@arndb.de>
To: David Miller <davem@davemloft.net>
Cc: linux-arm-kernel@lists.infradead.org,
	"Arnd Bergmann" <arnd@arndb.de>,
	netdev@vger.kernel.org, "Måns Rullgård" <mans@mansr.com>,
	linux-kernel@vger.kernel.org
Subject: [PATCH v2 6/7] net: nb8800: avoid uninitialized variable warning
Date: Fri, 29 Jan 2016 12:39:14 +0100	[thread overview]
Message-ID: <1454067557-3546883-7-git-send-email-arnd@arndb.de> (raw)
In-Reply-To: <1454067557-3546883-1-git-send-email-arnd@arndb.de>

The nb8800_poll() function initializes the 'next' variable in the
loop looking for new input data. We know this will be called at
least once because 'budget' is a guaranteed to be a positive number
when we enter the function, but the compiler doesn't know that
and warns when the variable is used later:

drivers/net/ethernet/aurora/nb8800.c: In function 'nb8800_poll':
drivers/net/ethernet/aurora/nb8800.c:350:21: warning: 'next' may be used uninitialized in this function [-Wmaybe-uninitialized]

Changing the 'while() {}' loop to 'do {} while()' makes it obvious
to the compiler what is going on so it no longer warns.

Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Acked-by: Mans Rullgard <mans@mansr.com>
---
 drivers/net/ethernet/aurora/nb8800.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/net/ethernet/aurora/nb8800.c b/drivers/net/ethernet/aurora/nb8800.c
index ecc4a334c507..f71ab2647a3b 100644
--- a/drivers/net/ethernet/aurora/nb8800.c
+++ b/drivers/net/ethernet/aurora/nb8800.c
@@ -302,7 +302,7 @@ static int nb8800_poll(struct napi_struct *napi, int budget)
 	nb8800_tx_done(dev);
 
 again:
-	while (work < budget) {
+	do {
 		struct nb8800_rx_buf *rxb;
 		unsigned int len;
 
@@ -330,7 +330,7 @@ again:
 		rxd->report = 0;
 		last = next;
 		work++;
-	}
+	} while (work < budget);
 
 	if (work) {
 		priv->rx_descs[last].desc.config |= DESC_EOC;
-- 
2.7.0

  parent reply	other threads:[~2016-01-29 11:41 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <1454067557-3546883-1-git-send-email-arnd@arndb.de>
2016-01-29 11:39 ` [PATCH v2 1/7] net: moxart: use correct accessors for DMA memory Arnd Bergmann
2016-01-29 11:39 ` [PATCH v2 2/7] net: davinci_cpdma: use dma_addr_t for DMA address Arnd Bergmann
2016-01-29 11:39 ` [PATCH v2 3/7] net: hp100: remove unnecessary #ifdefs Arnd Bergmann
2016-01-29 11:39 ` [PATCH v2 4/7] net: bgmac: clarify CONFIG_BCMA dependency Arnd Bergmann
2016-01-29 11:39 ` [PATCH v2 5/7] net: vxge: avoid unused function warnings Arnd Bergmann
2016-01-29 11:39 ` Arnd Bergmann [this message]
2016-01-29 11:39 ` [PATCH v2 7/7] net: tg3: avoid uninitialized variable warning Arnd Bergmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1454067557-3546883-7-git-send-email-arnd@arndb.de \
    --to=arnd@arndb.de \
    --cc=davem@davemloft.net \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mans@mansr.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®