From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756105AbcA2Llr (ORCPT ); Fri, 29 Jan 2016 06:41:47 -0500 Received: from mout.kundenserver.de ([212.227.126.130]:53199 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755906AbcA2Lln (ORCPT ); Fri, 29 Jan 2016 06:41:43 -0500 From: Arnd Bergmann To: David Miller Cc: linux-arm-kernel@lists.infradead.org, Arnd Bergmann , netdev@vger.kernel.org, Prashant Sreedharan , Michael Chan , linux-kernel@vger.kernel.org Subject: [PATCH v2 7/7] net: tg3: avoid uninitialized variable warning Date: Fri, 29 Jan 2016 12:39:15 +0100 Message-Id: <1454067557-3546883-8-git-send-email-arnd@arndb.de> X-Mailer: git-send-email 2.7.0 In-Reply-To: <1454067557-3546883-1-git-send-email-arnd@arndb.de> References: <1454067557-3546883-1-git-send-email-arnd@arndb.de> X-Provags-ID: V03:K0:8o89UAZeWIZC9AJ7HloiqVBLOBghr4cneJYlMtPPKba04aJqho4 AA0bLJ+4b3i73wynWCBWEkscA4Bam/DYfWcwaJkL/sQsuNNGaFG40Hfz90rDvIqdyUFXG8S t+llrndJhTni9DBxTXFKJKeded6LVI3y17NPT6y4h2TgrD90ZOJPJ7dQUgMPHp1qDJMbKWx IrMWq3LWkxRNNv6E5NyLg== X-UI-Out-Filterresults: notjunk:1;V01:K0:4PsJjvHBtcU=:Tn9y1/QZC/y1LgGTlqWCiE ua90ITr1Xor71wC5noRO+FLVmvOGP/dI+Zp7dNZFcvT0aaVN0bqyd5A+I8p6MAe1JtOwD/Imr Y0OAfbC5i2r6cqXjQUY7Zp5YDLVaPgxcPshjmDgg8RaLbmslgX02TE/lAt9Qx2QVsWrEcvNjO qLYUyXtGC50jSlkjW3BoBr+euNoNScUxyw1EXguBlx/gJjBkwZKvI4TRZw6bW9kjDVeeWaioR oVbhdRvMKumMeLwzbKFRs2e+S7oGlUXkgTmSQuGPcFlB0O8frun2HL0Md8ClrAn22nAyJ/mYM Hce8VGXej821HhLGCSsWX+e51BxNm79XEAwH2RWS5kmchtiAIAcYg0iWTTFxBYzQuAs1pvhUp 7qTmnET64bgEvFs2WOUc7lL8gWUnRlVPfallytW5p6cEzea8Ap8FzW1JBdAYcr8NS3FGt4S30 tW0F4uqwc7X2VtsGEDXEJ6SU21JpegAHvOT5+1f08j5hlL9Xn3dT9c6QaqGlKIzqRG3uKh1f1 SKV7TDk4oGbxEND3ssWRwJx120SV7gFCC6703WDFxoTNHBh5s36Q5Smj6mtaT1DXgXb1KLCTC QpwLSTP4D+bOQHF8onSwYHRMlmvi6jYJnH2F1enNF4AQ8Aba0KBhF2LN+FU9gA8I1a/hslxfC ooNSyeJEiF8cqcfwpAoslbOUzWXNg6U8gTInO4A/GdzI8kd+Gvlkdk/H5Bl2jK6+sJoM= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The tg3_set_eeprom() function correctly initializes the 'start' variable, but gcc generates a false warning: drivers/net/ethernet/broadcom/tg3.c: In function 'tg3_set_eeprom': drivers/net/ethernet/broadcom/tg3.c:12057:4: warning: 'start' may be used uninitialized in this function [-Wmaybe-uninitialized] I have not come up with a way to restructure the code in a way that avoids the warning without making it less readable, so this adds an initialization for the declaration to shut up that warning. Signed-off-by: Arnd Bergmann --- drivers/net/ethernet/broadcom/tg3.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/broadcom/tg3.c b/drivers/net/ethernet/broadcom/tg3.c index 9293675df7ba..49eea8981332 100644 --- a/drivers/net/ethernet/broadcom/tg3.c +++ b/drivers/net/ethernet/broadcom/tg3.c @@ -12016,7 +12016,7 @@ static int tg3_set_eeprom(struct net_device *dev, struct ethtool_eeprom *eeprom, int ret; u32 offset, len, b_offset, odd_len; u8 *buf; - __be32 start, end; + __be32 start = 0, end; if (tg3_flag(tp, NO_NVRAM) || eeprom->magic != TG3_EEPROM_MAGIC) -- 2.7.0