mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Ingo Molnar <mingo@kernel.org>
Cc: linux-kernel@vger.kernel.org, Jiri Olsa <jolsa@redhat.com>,
	Jiri Olsa <jolsa@kernel.org>, Wang Nan <wangnan0@huawei.com>,
	Arnaldo Carvalho de Melo <acme@redhat.com>
Subject: [PATCH 02/16] perf build: Fix feature-dump checks, we need to test all features
Date: Fri, 29 Jan 2016 18:17:39 -0300	[thread overview]
Message-ID: <1454102273-16431-3-git-send-email-acme@kernel.org> (raw)
In-Reply-To: <1454102273-16431-1-git-send-email-acme@kernel.org>

See http://www.infradead.org/rpr.html

From: Jiri Olsa <jolsa@redhat.com>

I see problem with test-all case speedup, because it does not
comprise checks for 32bits compilations, fix it.

The problem could be noticed by calling:

  make -C tools/perf feature-dump

That would end up misdetecting the feature-compile-x32, that, building
using 'gcc -mx32' needs stub headers not present in a fedora 23 devel
machine and thus fail to compile, but ended up appearing as detected,
i.e. present in tools/perf/FEATURE-DUMP as 'feature-compile-x32=1'.

With this fix it correctly appears as 'feature-compile-x32=0' and if we
uninstall the libc devel files for 32 bits (glibc-devel.i686), then the
relevant variable is flipped from 'feature-compile-32=1' to
'feature-compile-32=0'.

The same things happened for bionic and libbabeltrace, that were
misdetected because the are no tested in test-all.c

Reported-and-Tested-by: Arnaldo Carvalho de Melo <acme@redhat.com>
Signed-off-by: Jiri Olsa <jolsa@kernel.org>
Cc: Wang Nan <wangnan0@huawei.com>
Link: http://lkml.kernel.org/n/tip-u0sjaddf1r9m8icpd98ry7fz@git.kernel.org
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
---
 tools/build/Makefile.feature | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/tools/build/Makefile.feature b/tools/build/Makefile.feature
index 674c47d5f9d1..7bff2ea831cf 100644
--- a/tools/build/Makefile.feature
+++ b/tools/build/Makefile.feature
@@ -119,6 +119,14 @@ ifeq ($(feature-all), 1)
   # test-all.c passed - just set all the core feature flags to 1:
   #
   $(foreach feat,$(FEATURE_TESTS),$(call feature_set,$(feat)))
+  #
+  # test-all.c does not comprise these tests, so we need to
+  # for this case to get features proper values
+  #
+  $(call feature_check,compile-32)
+  $(call feature_check,compile-x32)
+  $(call feature_check,bionic)
+  $(call feature_check,libbabeltrace)
 else
   $(foreach feat,$(FEATURE_TESTS),$(call feature_check,$(feat)))
 endif
-- 
2.5.0

  parent reply	other threads:[~2016-01-29 21:18 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-01-29 21:17 [GIT PULL 00/16] perf/core improvements and fixes Arnaldo Carvalho de Melo
2016-01-29 21:17 ` [PATCH 01/16] tools build: Check basic headers for test-compile feature checker Arnaldo Carvalho de Melo
2016-01-29 21:17 ` Arnaldo Carvalho de Melo [this message]
2016-01-29 21:17 ` [PATCH 03/16] perf build: Remove all condition feature check {C,LD}FLAGS Arnaldo Carvalho de Melo
2016-01-29 21:17 ` [PATCH 04/16] perf build: Use feature dump file for build-test Arnaldo Carvalho de Melo
2016-01-29 21:17 ` [PATCH 05/16] perf tools: Speed up build-tests by reducing the number of builds tested Arnaldo Carvalho de Melo
2016-01-29 21:17 ` [PATCH 06/16] perf auxtrace: Add perf_evlist pointer to *info_priv_size() Arnaldo Carvalho de Melo
2016-01-29 21:17 ` [PATCH 07/16] perf buildid: Fix cpumode of buildid event Arnaldo Carvalho de Melo
2016-01-29 21:17 ` [PATCH 08/16] perf test: Check environment before start real BPF test Arnaldo Carvalho de Melo
2016-01-29 21:17 ` [PATCH 09/16] perf test: Improve bp_signal Arnaldo Carvalho de Melo
2016-01-29 21:17 ` [PATCH 10/16] perf tools: Move timestamp creation to util Arnaldo Carvalho de Melo
2016-01-29 21:17 ` [PATCH 11/16] perf record: Use OPT_BOOLEAN_SET for buildid cache related options Arnaldo Carvalho de Melo
2016-01-29 21:17 ` [PATCH 12/16] perf kvm/{x86,s390}: Remove dependency on uapi/kvm_perf.h Arnaldo Carvalho de Melo
2016-01-29 21:17 ` [PATCH 13/16] perf kvm/{x86,s390}: Remove const from kvm_events_tp Arnaldo Carvalho de Melo
2016-01-29 21:17 ` [PATCH 14/16] perf kvm/powerpc: Port perf kvm stat to powerpc Arnaldo Carvalho de Melo
2016-01-29 21:17 ` [PATCH 15/16] perf kvm/powerpc: Add support for HCALL reasons Arnaldo Carvalho de Melo
2016-01-29 21:17 ` [PATCH 16/16] perf build: Align the names of the build tests: Arnaldo Carvalho de Melo
2016-02-03 10:02 ` [GIT PULL 00/16] perf/core improvements and fixes Ingo Molnar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1454102273-16431-3-git-send-email-acme@kernel.org \
    --to=acme@kernel.org \
    --cc=acme@redhat.com \
    --cc=jolsa@kernel.org \
    --cc=jolsa@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@kernel.org \
    --cc=wangnan0@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome