From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932622AbcBANK1 (ORCPT ); Mon, 1 Feb 2016 08:10:27 -0500 Received: from mail-wm0-f41.google.com ([74.125.82.41]:33668 "EHLO mail-wm0-f41.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932481AbcBANKW (ORCPT ); Mon, 1 Feb 2016 08:10:22 -0500 From: "=?UTF-8?q?Javier=20Gonz=C3=A1lez?=" X-Google-Original-From: =?UTF-8?q?Javier=20Gonz=C3=A1lez?= To: mb@lightnvm.io Cc: linux-kernel@vger.kernel.org, linux-block@vger.kernel.org, =?UTF-8?q?Javier=20Gonz=C3=A1lez?= Subject: [PATCH] lightnvm: invalidate addresses on multipage fail Date: Mon, 1 Feb 2016 14:10:02 +0100 Message-Id: <1454332202-13368-1-git-send-email-javier@javigon.com> X-Mailer: git-send-email 2.1.4 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org If a page mapping fails when mapping several pages in a single write bio request, make sure that already mapped pages are invalidated. Since other legit mappings coming from a different bio request might have occurred, rolling back the failed bio is a difficult, unnecessary overhead; in part because when a mapping fails something bad has happened already. Still, invalidating pages in the failed bio will help GC. Signed-off-by: Javier González --- drivers/lightnvm/rrpc.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/lightnvm/rrpc.c b/drivers/lightnvm/rrpc.c index c4d0b04..29befe9 100644 --- a/drivers/lightnvm/rrpc.c +++ b/drivers/lightnvm/rrpc.c @@ -730,6 +730,7 @@ static int rrpc_read_ppalist_rq(struct rrpc *rrpc, struct bio *bio, } else { BUG_ON(is_gc); rrpc_unlock_laddr(rrpc, r); + rrpc_invalidate_range(rrpc, laddr, i + 1); nvm_dev_dma_free(rrpc->dev, rqd->ppa_list, rqd->dma_ppa_list); return NVM_IO_DONE; -- 2.1.4