From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752203AbcBAPyE (ORCPT ); Mon, 1 Feb 2016 10:54:04 -0500 Received: from mail-yk0-f170.google.com ([209.85.160.170]:33963 "EHLO mail-yk0-f170.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751538AbcBAPyC (ORCPT ); Mon, 1 Feb 2016 10:54:02 -0500 From: Insu Yun To: ed.cashin@acm.org, linux-kernel@vger.kernel.org Cc: taesoo@gatech.edu, yeongjin.jang@gatech.edu, insu@gatech.edu, changwoo@gatech.edu, Insu Yun Subject: [PATCH] aoe: remove unnecessary check for failing kthread creation Date: Mon, 1 Feb 2016 10:53:59 -0500 Message-Id: <1454342039-14068-1-git-send-email-wuninsu@gmail.com> X-Mailer: git-send-email 1.9.1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org When kthread_run fails, it returns ERR, not NULL. Therefore, NULL checking is redundant. (https://www.kernel.org/doc/htmldocs/device-drivers/API-kthread-run.html) Signed-off-by: Insu Yun --- drivers/block/aoe/aoecmd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/block/aoe/aoecmd.c b/drivers/block/aoe/aoecmd.c index d048d20..4213114 100644 --- a/drivers/block/aoe/aoecmd.c +++ b/drivers/block/aoe/aoecmd.c @@ -1327,7 +1327,7 @@ aoe_ktstart(struct ktstate *k) init_completion(&k->rendez); task = kthread_run(kthread, k, "%s", k->name); - if (task == NULL || IS_ERR(task)) + if (IS_ERR(task)) return -ENOMEM; k->task = task; wait_for_completion(&k->rendez); /* allow kthread to start */ -- 1.9.1