From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753369AbcBAUAq (ORCPT ); Mon, 1 Feb 2016 15:00:46 -0500 Received: from mail-pf0-f181.google.com ([209.85.192.181]:33712 "EHLO mail-pf0-f181.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752704AbcBAUAp (ORCPT ); Mon, 1 Feb 2016 15:00:45 -0500 Message-ID: <1454356843.7627.187.camel@edumazet-glaptop2.roam.corp.google.com> Subject: Re: [PATCH 4/4] sched,time: only call account_{user,sys,guest,idle}_time once a jiffy From: Eric Dumazet To: riel@redhat.com Cc: linux-kernel@vger.kernel.org, tglx@linutronix.de, peterz@infradead.org, fweisbec@gmail.com, clark@redhat.com, luto@amacapital.net, mingo@kernel.org Date: Mon, 01 Feb 2016 12:00:43 -0800 In-Reply-To: <1454354466-31309-5-git-send-email-riel@redhat.com> References: <1454354466-31309-1-git-send-email-riel@redhat.com> <1454354466-31309-5-git-send-email-riel@redhat.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.10.4-0ubuntu2 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 2016-02-01 at 14:21 -0500, riel@redhat.com wrote: > From: Rik van Riel > > #ifdef CONFIG_VIRT_CPU_ACCOUNTING_GEN > +static bool vtime_jiffies_changed(struct task_struct *tsk, unsigned long now) > +{ > + if (tsk->vtime_jiffies == jiffies) > + return false; > + > + tsk->vtime_jiffies = jiffies; > + return true; > +} I am guessing you intended to use 'now' instead of jiffies ?