mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Joe Perches <joe@perches.com>
To: Ingo Molnar <mingo@kernel.org>, Wei Tang <tangwei@cmss.chinamobile.com>
Cc: akpm@linux-foundation.org, peterz@infradead.org, tj@ke.rnel.org,
	kirill.shutemov@linux.intel.com, jason.low2@hp.com,
	xypron.glpk@gmx.de, oleg@redhat.com, koct9i@gmail.com,
	josh@joshtriplett.org, ebiederm@xmission.com, cyphar@cyphar.com,
	linux-kernel@vger.kernel.org,
	Linus Torvalds <torvalds@linux-foundation.org>,
	Thomas Gleixner <tglx@linutronix.de>,
	Peter Zijlstra <a.p.zijlstra@chello.nl>
Subject: Re: [PATCH] treewide: Use 'sizeof(x)' instead of 'sizeof x'
Date: Tue, 02 Feb 2016 05:58:56 -0800	[thread overview]
Message-ID: <1454421536.7291.14.camel@perches.com> (raw)
In-Reply-To: <20160202112841.GA14524@gmail.com>

On Tue, 2016-02-02 at 12:28 +0100, Ingo Molnar wrote:
> * Ingo Molnar <mingo@kernel.org> wrote:
> 
> > If anyone feels strongly about accepting such patches, then the right solution 
> > is to create a Coccinelle semantic patch to run over the whole kernel and get 
> > over with the churn once and for all.
> 
> So applying a semantic patch like this to all .c files:
> 
>   @@ expression E; @@
>   -sizeof E
>   +sizeof(E)
>   @@ expression E2; @@
>   -sizeof((E2))
>   +sizeof(E2)
> 
> Produces the single patch below for the whole kernel - instead of generating a 
> churn of 1,000+ patches ...

If this isn't a joke, a nicer way to submit this is
by subsystem and not as a single huge patch.

This allows subsystem maintainers to reduce patch
contention as this patch already doesn't apply
to -next.

  reply	other threads:[~2016-02-02 13:59 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-02-02  7:53 [PATCH] kernel/fork.c: use sizeof() instead of sizeof Wei Tang
2016-02-02  9:11 ` Ingo Molnar
2016-02-02 11:28   ` [PATCH] treewide: Use 'sizeof(x)' instead of 'sizeof x' Ingo Molnar
2016-02-02 13:58     ` Joe Perches [this message]
2016-02-02 15:45   ` [PATCH] kernel/fork.c: use sizeof() instead of sizeof Al Viro
2016-02-02 17:02     ` Joe Perches
2016-02-02 17:11       ` Al Viro
2016-02-02 17:21         ` Joe Perches
     [not found]     ` <CAOviyajXB2y5zuFhdRPQfVSe_NYvaFjjUz6f86e791AvFPYfMw@mail.gmail.com>
2016-02-02 17:04       ` Al Viro
2016-02-03  3:46         ` Kevin Easton
2016-02-03  4:02           ` Al Viro

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1454421536.7291.14.camel@perches.com \
    --to=joe@perches.com \
    --cc=a.p.zijlstra@chello.nl \
    --cc=akpm@linux-foundation.org \
    --cc=cyphar@cyphar.com \
    --cc=ebiederm@xmission.com \
    --cc=jason.low2@hp.com \
    --cc=josh@joshtriplett.org \
    --cc=kirill.shutemov@linux.intel.com \
    --cc=koct9i@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@kernel.org \
    --cc=oleg@redhat.com \
    --cc=peterz@infradead.org \
    --cc=tangwei@cmss.chinamobile.com \
    --cc=tglx@linutronix.de \
    --cc=tj@ke.rnel.org \
    --cc=torvalds@linux-foundation.org \
    --cc=xypron.glpk@gmx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®