From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932196AbcBBWl3 (ORCPT ); Tue, 2 Feb 2016 17:41:29 -0500 Received: from p3plsmtps2ded02.prod.phx3.secureserver.net ([208.109.80.59]:42396 "EHLO p3plsmtps2ded02.prod.phx3.secureserver.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751957AbcBBWl1 (ORCPT ); Tue, 2 Feb 2016 17:41:27 -0500 x-originating-ip: 72.167.245.219 From: Haiyang Zhang To: davem@davemloft.net, netdev@vger.kernel.org Cc: haiyangz@microsoft.com, kys@microsoft.com, olaf@aepfle.de, vkuznets@redhat.com, linux-kernel@vger.kernel.org, driverdev-devel@linuxdriverproject.org Subject: [PATCH net-next] hv_netvsc: Increase delay for RNDIS_STATUS_NETWORK_CHANGE Date: Tue, 2 Feb 2016 16:15:56 -0800 Message-Id: <1454458556-10591-1-git-send-email-haiyangz@microsoft.com> X-Mailer: git-send-email 1.7.4.1 X-CMAE-Envelope: MS4wfJFmMVX1aKLtayj2Y+IInD3ZNLmQqjb/S/v8VcgDwjhElxLRyD3MmNyteRch3W7gL3eJ7lrVxKmcXRGZyLtMwApEMO9tlxgZ7Ih5Qp5/IUKgBsPPR1ps DdFRGdADi8iLn8wmXE4NxOgPz7Ihip0UYWlzzgDTWLJVpEBd8/2hqJ5PqgyeneB2I/aJGfCe0dN2OOcg+4IJ0Z4sJqrpB63KMgt1D31Qc/PNC5EK5k/c1420 w864aCeuBFCQlhSsV1FTONaEiq71Hdi1x1y/oAozohmV3tAI0/JZ2/sA0QRcdHVZ5BIOwFdYrroO9qx/6sJwt3hL6fsBr12/l9zp0mMRheRWG0IfEPUaZlmT XV6yb5IDeeRXF8tiYy6WZuR5d5TMeAKA6JQ5KL14VhXHawR6Ibue/3HJ1Buns4RaAGCEvMxUCI37ja2TMe81d3ZchAxJlw== Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org We simulates a link down period for RNDIS_STATUS_NETWORK_CHANGE message to trigger DHCP renew. User daemons may need multiple seconds to trigger the link down event. (e.g. ifplugd: 5sec, network-manager: 4sec.) So update this link down period to 10 sec to properly trigger DHCP renew. Signed-off-by: Haiyang Zhang --- drivers/net/hyperv/netvsc_drv.c | 10 ++++++++-- 1 files changed, 8 insertions(+), 2 deletions(-) diff --git a/drivers/net/hyperv/netvsc_drv.c b/drivers/net/hyperv/netvsc_drv.c index 1d3a665..6f23973 100644 --- a/drivers/net/hyperv/netvsc_drv.c +++ b/drivers/net/hyperv/netvsc_drv.c @@ -43,6 +43,8 @@ #define RING_SIZE_MIN 64 #define LINKCHANGE_INT (2 * HZ) +/* Extra delay for RNDIS_STATUS_NETWORK_CHANGE: */ +#define LINKCHANGE_DELAY (8 * HZ) static int ring_size = 128; module_param(ring_size, int, S_IRUGO); MODULE_PARM_DESC(ring_size, "Ring buffer size (# of pages)"); @@ -964,6 +966,7 @@ static void netvsc_link_change(struct work_struct *w) return; } ndev_ctx->last_reconfig = jiffies; + delay = LINKCHANGE_INT; spin_lock_irqsave(&ndev_ctx->lock, flags); if (!list_empty(&ndev_ctx->reconfig_events)) { @@ -1009,8 +1012,11 @@ static void netvsc_link_change(struct work_struct *w) netif_tx_stop_all_queues(net); event->event = RNDIS_STATUS_MEDIA_CONNECT; spin_lock_irqsave(&ndev_ctx->lock, flags); - list_add_tail(&event->list, &ndev_ctx->reconfig_events); + list_add(&event->list, &ndev_ctx->reconfig_events); spin_unlock_irqrestore(&ndev_ctx->lock, flags); + + ndev_ctx->last_reconfig += LINKCHANGE_DELAY; + delay = LINKCHANGE_INT + LINKCHANGE_DELAY; reschedule = true; } break; @@ -1025,7 +1031,7 @@ static void netvsc_link_change(struct work_struct *w) * second, handle next reconfig event in 2 seconds. */ if (reschedule) - schedule_delayed_work(&ndev_ctx->dwork, LINKCHANGE_INT); + schedule_delayed_work(&ndev_ctx->dwork, delay); } static void netvsc_free_netdev(struct net_device *netdev) -- 1.7.4.1