From: "Radim Krčmář" <rkrcmar@redhat.com>
To: linux-kernel@vger.kernel.org
Cc: kvm@vger.kernel.org, Paolo Bonzini <pbonzini@redhat.com>,
Yuki Shibuya <shibuya.yk@ncos.nec.co.jp>
Subject: [PATCH 0/4] KVM: x86: change and fix PIT discard tick policy
Date: Wed, 3 Feb 2016 17:23:01 +0100 [thread overview]
Message-ID: <1454516585-28491-1-git-send-email-rkrcmar@redhat.com> (raw)
[3/4] fixes a bug where legacy NMI watchdog doesn't receive NMIs if a
CPU that handles PIT interrupts hangs with masked interrupts.
Remaining patches try to make the code nicer where necessary.
([1/4] makes you think that it fixes a bug, but that would be fixed by
skipping the path in [3/4].)
[3/4] only changes the discard policy. A change that allows legacy NMI
watchdog with the reinject policy is below, but conscience doesn't allow
me to sign it off.
# diff --git a/arch/x86/kvm/i8254.c b/arch/x86/kvm/i8254.c
@@ -274,6 +274,10 @@ static void pit_do_work(struct kthread_work *work)
int i;
struct kvm_kpit_state *ps = &pit->pit_state;
+ if (atomic_read(&kvm->arch.vapics_in_nmi_mode) > 0)
+ kvm_for_each_vcpu(i, vcpu, kvm)
+ kvm_apic_nmi_wd_deliver(vcpu);
+
if (ps->reinject && !atomic_xchg(&ps->irq_ack, 0))
return;
@@ -289,9 +293,6 @@ static void pit_do_work(struct kthread_work *work)
* VCPUs and only when LVT0 is in NMI mode. The interrupt can
* also be simultaneously delivered through PIC and IOAPIC.
*/
- if (atomic_read(&kvm->arch.vapics_in_nmi_mode) > 0)
- kvm_for_each_vcpu(i, vcpu, kvm)
- kvm_apic_nmi_wd_deliver(vcpu);
}
static enum hrtimer_restart pit_timer_fn(struct hrtimer *data)
Radim Krčmář (4):
KVM: x86: fix interrupt dropping race in PIT
KVM: x86: refactor PIT state inject_lock
KVM: x86: change PIT discard tick policy
KVM: x86: remove notifiers from PIT discard policy
arch/x86/kvm/i8254.c | 122 ++++++++++++++++++++++++++-------------------------
arch/x86/kvm/i8254.h | 4 +-
arch/x86/kvm/x86.c | 6 +--
3 files changed, 67 insertions(+), 65 deletions(-)
--
2.7.0
next reply other threads:[~2016-02-03 16:24 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-03 16:23 Radim Krčmář [this message]
2016-02-03 16:23 ` [PATCH 1/4] KVM: x86: fix interrupt dropping race in PIT Radim Krčmář
2016-02-04 13:35 ` Radim Krčmář
2016-02-03 16:23 ` [PATCH 2/4] KVM: x86: refactor PIT state inject_lock Radim Krčmář
2016-02-03 16:45 ` Paolo Bonzini
2016-02-04 13:13 ` Radim Krčmář
2016-02-03 16:23 ` [PATCH 3/4] KVM: x86: change PIT discard tick policy Radim Krčmář
2016-02-03 16:48 ` Paolo Bonzini
2016-02-03 16:23 ` [PATCH 4/4] KVM: x86: remove notifiers from PIT discard policy Radim Krčmář
2016-02-03 16:51 ` Paolo Bonzini
2016-02-04 13:15 ` Radim Krčmář
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1454516585-28491-1-git-send-email-rkrcmar@redhat.com \
--to=rkrcmar@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pbonzini@redhat.com \
--cc=shibuya.yk@ncos.nec.co.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®